diff options
| author | Firas Sammoura <fsammoura@google.com> | 2022-09-12 16:39:42 +0000 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-09-12 19:46:38 +0000 |
| commit | 1cd8f2fca2dfcfd1c0f5f9cd22f822ede4e1b7a4 (patch) | |
| tree | bf73169b36dcd812fc125d113f0159ecddf151eb | |
| parent | 8051471c0a8720991042bc47c6328a9f4a64cde0 (diff) | |
| download | chrome-ec-1cd8f2fca2dfcfd1c0f5f9cd22f822ede4e1b7a4.tar.gz | |
test: modify comments in read_match_secret fail invalid param
Remove the comments before TEST_ASSERT in
test_fp_command_read_match_secret_fail_fgr_large_than_max and
test_fp_command_read_match_secret_fail_fgr_less_than_zero test
functions. The comments are not necessary since the code is
self-documenting by itself.
BRANCH=None
BUG=b:242720387
TEST=make run-fpsensor_state
TEST=make runhosttests
Signed-off-by: Firas Sammoura <fsammoura@google.com>
Change-Id: I0e87201f2418ea5017733db8a175bbdaa577020e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891671
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Bobby Casey <bobbycasey@google.com>
| -rw-r--r-- | test/fpsensor_state.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/test/fpsensor_state.c b/test/fpsensor_state.c index 36611c3119..85aa60e5b9 100644 --- a/test/fpsensor_state.c +++ b/test/fpsensor_state.c @@ -193,10 +193,6 @@ test_static int test_fp_command_read_match_secret_fail_fgr_less_than_zero(void) .fgr = -1, }; - /* - * FP_COMMAND_READ_MATCH_SECRET should have if the finger number is < - * 0 - */ TEST_ASSERT(test_send_host_command(EC_CMD_FP_READ_MATCH_SECRET, 0, &test_match_secret, sizeof(test_match_secret), NULL, @@ -211,10 +207,7 @@ test_static int test_fp_command_read_match_secret_fail_fgr_large_than_max(void) struct ec_params_fp_read_match_secret test_match_secret = { .fgr = FP_MAX_FINGER_COUNT, }; - /* - * FP_COMMAND_READ_MATCH_SECRET should have if the finger number is < - * 0 - */ + TEST_ASSERT(test_send_host_command(EC_CMD_FP_READ_MATCH_SECRET, 0, &test_match_secret, sizeof(test_match_secret), NULL, |