diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2018-09-19 11:53:59 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-09-19 20:47:16 +0000 |
| commit | d8de510aa7bdfb7c43621c7d48b7ca3ab372e3c7 (patch) | |
| tree | f83ba6274d1e6a9c3b2df448976b90c444115f1e | |
| parent | 93d992e8fa82a0f177a8f6564025adb02855e529 (diff) | |
| download | chrome-ec-d8de510aa7bdfb7c43621c7d48b7ca3ab372e3c7.tar.gz | |
Fizz: Remove remote temp sensor 2
Fizz has been shipped with TMP431, which has only one remote sensor.
This patch removes the one which doesn't exist on the boards.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=chromium:880705
BRANCH=none
TEST=Verify local and remote sensor report expected temperatures.
Verify the fan spins as expected.
> temps
TMP431_Internal : 304 K = 31 C 37%
TMP431_Sensor_1 : 301 K = 28 C
$ ectool temps all
0: 304 K
1: 301 K
Change-Id: I2346444f1331faaf32b407a18ba96302b7a166e6
Reviewed-on: https://chromium-review.googlesource.com/1234735
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | board/fizz/board.c | 13 | ||||
| -rw-r--r-- | board/fizz/board.h | 1 |
2 files changed, 6 insertions, 8 deletions
diff --git a/board/fizz/board.c b/board/fizz/board.c index da25199a9e..f8de83b255 100644 --- a/board/fizz/board.c +++ b/board/fizz/board.c @@ -276,17 +276,17 @@ uint16_t tcpc_get_alert_status(void) } /* + * TMP431 has one local and one remote sensor. + * * Temperature sensors data; must be in same order as enum temp_sensor_id. * Sensor index and name must match those present in coreboot: * src/mainboard/google/${board}/acpi/dptf.asl */ const struct temp_sensor_t temp_sensors[] = { - {"TMP432_Internal", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, + {"TMP431_Internal", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, TMP432_IDX_LOCAL, 4}, - {"TMP432_Sensor_1", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, + {"TMP431_Sensor_1", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, TMP432_IDX_REMOTE1, 4}, - {"TMP432_Sensor_2", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, - TMP432_IDX_REMOTE2, 4}, }; BUILD_ASSERT(ARRAY_SIZE(temp_sensors) == TEMP_SENSOR_COUNT); @@ -300,9 +300,8 @@ struct ec_thermal_config thermal_params[] = { * fan_off, fan_max */ {{0, C_TO_K(80), C_TO_K(81)}, {0, C_TO_K(78), 0}, - C_TO_K(4), C_TO_K(76)}, /* TMP432_Internal */ - {{0, 0, 0}, {0, 0, 0}, 0, 0}, /* TMP432_Sensor_1 */ - {{0, 0, 0}, {0, 0, 0}, 0, 0}, /* TMP432_Sensor_2 */ + C_TO_K(4), C_TO_K(76)}, /* TMP431_Internal */ + {{0, 0, 0}, {0, 0, 0}, 0, 0}, /* TMP431_Sensor_1 */ }; BUILD_ASSERT(ARRAY_SIZE(thermal_params) == TEMP_SENSOR_COUNT); diff --git a/board/fizz/board.h b/board/fizz/board.h index ef7bbb0c65..297ab9c1d4 100644 --- a/board/fizz/board.h +++ b/board/fizz/board.h @@ -199,7 +199,6 @@ enum power_signal { enum temp_sensor_id { TEMP_SENSOR_CHARGER, /* BD99992GW SYSTHERM1 */ TEMP_SENSOR_DRAM, /* BD99992GW SYSTHERM2 */ - TEMP_SENSOR_EMMC, /* BD99992GW SYSTHERM3 */ TEMP_SENSOR_COUNT }; |