summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaisuke Nojiri <dnojiri@chromium.org>2018-10-16 16:01:16 -0700
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2018-11-20 19:01:09 +0000
commitbdf94d8166ef9b5d1f487845c84b467499d33760 (patch)
tree3d4ccef43ab8b9433561a395fb1b461b865a47d0
parentb9a96bde3e55519f9e54418b4bd849ab97222200 (diff)
downloadchrome-ec-bdf94d8166ef9b5d1f487845c84b467499d33760.tar.gz
Fan: Fix memory access error in pwm_fan_init
This patch fixes memory access error introduced by CL:1169910. Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> BUG=b:112293333 BRANCH=none TEST=Verified EC boots on Sona. Change-Id: I81ab6b9235f51f5e101e286d266d28e41bea4b11 Reviewed-on: https://chromium-review.googlesource.com/1285290 Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Tino Liu <tino.liu@quanta.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1344573 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
-rw-r--r--common/fan.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/common/fan.c b/common/fan.c
index 2ed213316d..fb97b13eda 100644
--- a/common/fan.c
+++ b/common/fan.c
@@ -450,8 +450,9 @@ static void pwm_fan_init(void)
memcpy(&state, prev, sizeof(state));
} else {
memset(&state, 0, sizeof(state));
- state.rpm = fan_percent_to_rpm(FAN_CH(fan),
- CONFIG_FAN_INIT_SPEED);
+ for (fan = 0; fan < CONFIG_FANS; fan++)
+ state.rpm = fan_percent_to_rpm(FAN_CH(fan),
+ CONFIG_FAN_INIT_SPEED);
}
for (fan = 0; fan < CONFIG_FANS; fan++) {