diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2018-11-21 09:59:49 -0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-11-26 17:02:19 +0000 |
| commit | 258e4a3d2c89cbf1f81e384bc179cb748611f24e (patch) | |
| tree | 84a519d54d81c1f77cea54a06487f51635519573 | |
| parent | 71c81e5d3404f09577f6b41d2b4b7e7597a77378 (diff) | |
| download | chrome-ec-258e4a3d2c89cbf1f81e384bc179cb748611f24e.tar.gz | |
CEC: Set pull-up high
GPIO pins don't get set high or low after sysjump. This cause
CEC not to work if RO image doesn't set CEC_GPIO_PULL_UP.
This patch sets CEC_GPIO_PULL_UP to high in cec_init.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:119901859
BRANCH=none
TEST=Verify CEC_PULL_UP=1 on Teemo in normal mode and recovery mode.
Change-Id: I0c88a789a8731054c2e4b0bb1066529933473b70
Reviewed-on: https://chromium-review.googlesource.com/c/1346990
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Stefan Adolfsson <sadolfsson@chromium.org>
| -rw-r--r-- | chip/npcx/cec.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chip/npcx/cec.c b/chip/npcx/cec.c index 56e74bd429..a11fe42645 100644 --- a/chip/npcx/cec.c +++ b/chip/npcx/cec.c @@ -1157,6 +1157,9 @@ static void cec_init(void) /* Enable capture TCNT1 into TCRA and preset TCNT1. */ SET_BIT(NPCX_TMCTRL(mdl), NPCX_TMCTRL_TAEN); + /* If RO doesn't set it, RW needs to set it explicitly. */ + gpio_set_level(CEC_GPIO_PULL_UP, 1); + CPRINTS("CEC initialized"); } DECLARE_HOOK(HOOK_INIT, cec_init, HOOK_PRIO_LAST); |