diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2021-12-28 17:45:18 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-12-29 03:07:04 +0000 |
| commit | afa982f68705d35522e19133650d3985677a2d36 (patch) | |
| tree | 044d6416511e6bdd7a1f9df0a9eaeabe97283c43 | |
| parent | 08d9e212d0086a1bff68e78251eedf6434b9245c (diff) | |
| download | chrome-ec-afa982f68705d35522e19133650d3985677a2d36.tar.gz | |
ap ro verification: add log entry for the 'unsupported' case
Let's have different log entries for the case when AP RO verification
is provisioned but failed, and when it is supported.
BUG=b:211762871
TEST=none
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Change-Id: If99c89e6c6c0d10eec2d9e9c97d13e85bb3f1f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3360091
Tested-by: Vadim Bendebury <vbendeb@gmail.com>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
| -rw-r--r-- | common/ap_ro_integrity_check.c | 3 | ||||
| -rw-r--r-- | include/flash_log.h | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/common/ap_ro_integrity_check.c b/common/ap_ro_integrity_check.c index 939a618c64..59ce15a25b 100644 --- a/common/ap_ro_integrity_check.c +++ b/common/ap_ro_integrity_check.c @@ -1447,10 +1447,10 @@ static uint8_t do_ap_ro_check(void) if (rv != ROV_SUCCEEDED) { /* Failure reason has already been reported. */ - ap_ro_add_flash_event(APROF_CHECK_FAILED); if ((rv == ROV_FAILED) || check_is_required()) { apro_result = AP_RO_FAIL; + ap_ro_add_flash_event(APROF_CHECK_FAILED); keep_ec_in_reset(); /* * Map failures into EC_ERROR_CRC, this will make sure @@ -1465,6 +1465,7 @@ static uint8_t do_ap_ro_check(void) } apro_result = AP_RO_UNSUPPORTED_TRIGGERED; + ap_ro_add_flash_event(APROF_CHECK_UNSUPPORTED); return EC_ERROR_UNIMPLEMENTED; } diff --git a/include/flash_log.h b/include/flash_log.h index 14d65953b6..cc6c292d49 100644 --- a/include/flash_log.h +++ b/include/flash_log.h @@ -99,6 +99,7 @@ enum ap_ro_verification_ev { APROF_SPACE_INVALID = 5, APROF_CHECK_FAILED = 6, APROF_CHECK_SUCCEEDED = 7, + APROF_CHECK_UNSUPPORTED = 8, }; struct ap_ro_entry_payload { |