diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2014-06-03 15:38:54 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-06-04 21:01:43 +0000 |
| commit | 1732ba691e7cafc83f25ce23eef61c9c98794de1 (patch) | |
| tree | 3285c31e989fd0817c49de01900cf03000a3a6af | |
| parent | 2a7ea567829eae57fa7b05bf23a57dd13823d56e (diff) | |
| download | chrome-ec-1732ba691e7cafc83f25ce23eef61c9c98794de1.tar.gz | |
Make Ctrl-S and Ctrl-Q match the rest of the world
Traditionally, Ctrl-S means XOFF and Ctrl-Q means XON
(http://en.wikipedia.org/wiki/Software_flow_control)
We've had it reversed on the EC console, and it's kind of annoying.
BUG=none
BRANCH=ToT
TEST=make buildall
Boot, watch the EC console. Hit Ctrl-S to stop the output, Ctrl-Q to
continue.
Change-Id: Ib2b9ba9a2688229d5d44f3b3f845208499ef09ff
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/202532
Reviewed-by: Randall Spangler <rspangler@chromium.org>
| -rw-r--r-- | common/uart_buffering.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/common/uart_buffering.c b/common/uart_buffering.c index 7d0b51ccf4..6e93804e61 100644 --- a/common/uart_buffering.c +++ b/common/uart_buffering.c @@ -157,11 +157,11 @@ void uart_process_input(void) for (i = cur_head; i != rx_buf_head; i = RX_BUF_NEXT(i)) { int c = rx_buf[i]; - if (c == CTRL('Q')) { + if (c == CTRL('S')) { /* Software flow control - XOFF */ uart_suspended = 1; uart_tx_stop(); - } else if (c == CTRL('S')) { + } else if (c == CTRL('Q')) { /* Software flow control - XON */ uart_suspended = 0; uart_tx_start(); @@ -197,11 +197,11 @@ void uart_process_input(void) int c = uart_read_char(); int rx_buf_next = RX_BUF_NEXT(rx_buf_head); - if (c == CTRL('Q')) { + if (c == CTRL('S')) { /* Software flow control - XOFF */ uart_suspended = 1; uart_tx_stop(); - } else if (c == CTRL('S')) { + } else if (c == CTRL('Q')) { /* Software flow control - XON */ uart_suspended = 0; uart_tx_start(); |