diff options
| author | ChromeOS Developer <dparker@chromium.org> | 2014-02-07 11:52:47 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-02-12 00:40:33 +0000 |
| commit | a78c59e4acbbd5b85c221b477b2db43f5e5d679b (patch) | |
| tree | cdb769b6f64cbc72024e113cf79ffea74bf1a602 | |
| parent | dad376eada6d4e31550e4b241fb3e765d6e69ea7 (diff) | |
| download | chrome-ec-a78c59e4acbbd5b85c221b477b2db43f5e5d679b.tar.gz | |
Add comment about matching temp sensor index and name with coreboot
BUG=None
BRANCH=rambi
TEST=None
Change-Id: I702173af23e6207129149bdb83ec7116fec8af66
Signed-off-by: Dave Parker <dparker@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/185394
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
| -rw-r--r-- | board/rambi/board.c | 6 | ||||
| -rw-r--r-- | board/squawks/board.c | 6 |
2 files changed, 10 insertions, 2 deletions
diff --git a/board/rambi/board.c b/board/rambi/board.c index d4497d9901..75ad5fd4e0 100644 --- a/board/rambi/board.c +++ b/board/rambi/board.c @@ -177,7 +177,11 @@ const struct i2c_port_t i2c_ports[] = { }; const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); -/* Temperature sensors data; must be in same order as enum temp_sensor_id. */ +/* + * Temperature sensors data; must be in same order as enum temp_sensor_id. + * Sensor index and name must match those present in coreboot: + * src/mainboard/google/${board}/acpi/dptf.asl + */ const struct temp_sensor_t temp_sensors[] = { {"ECInternal", TEMP_SENSOR_TYPE_BOARD, chip_temp_sensor_get_val, 0, 4}, {"TMP432_Internal", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, diff --git a/board/squawks/board.c b/board/squawks/board.c index 2b783f655f..fd22aecc78 100644 --- a/board/squawks/board.c +++ b/board/squawks/board.c @@ -178,7 +178,11 @@ const struct i2c_port_t i2c_ports[] = { }; const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports); -/* Temperature sensors data; must be in same order as enum temp_sensor_id. */ +/* + * Temperature sensors data; must be in same order as enum temp_sensor_id. + * Sensor index and name must match those present in coreboot: + * src/mainboard/google/${board}/acpi/dptf.asl + */ const struct temp_sensor_t temp_sensors[] = { {"ECInternal", TEMP_SENSOR_TYPE_BOARD, chip_temp_sensor_get_val, 0, 4}, {"TMP432_Internal", TEMP_SENSOR_TYPE_BOARD, tmp432_get_val, |