summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Bettis <jbettis@google.com>2022-10-18 11:43:41 -0600
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-10-18 19:30:50 +0000
commita13ed8771e1751ea6966e21b5c73078f1df8b02c (patch)
treeeeadd2152529531c6cbefb89e1ddb7c63c105b90
parent577400670ec56e979ac0dfe1841390eb0d7b10c8 (diff)
downloadchrome-ec-a13ed8771e1751ea6966e21b5c73078f1df8b02c.tar.gz
cq: Remove unnecessary lcov command
There is a lcov command that is merging 2 files that are already combined. Remove it, and change the dependent steps. BRANCH=None BUG=None TEST=Ran before and after and diffed the metrics Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: Ifb78cbec97983198baf00077c3bb945ec31f350f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3964534 Tested-by: Jeremy Bettis <jbettis@chromium.org> Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Abe Levkoy <alevkoy@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
-rwxr-xr-xzephyr/firmware_builder.py21
1 files changed, 1 insertions, 20 deletions
diff --git a/zephyr/firmware_builder.py b/zephyr/firmware_builder.py
index 1cba339d5e..545d31312d 100755
--- a/zephyr/firmware_builder.py
+++ b/zephyr/firmware_builder.py
@@ -326,25 +326,6 @@ def test(opts):
).stdout
_extract_lcov_summary("EC_ZEPHYR_MERGED", metrics, output)
- cmd = [
- "/usr/bin/lcov",
- "-o",
- build_dir / "lcov_unfiltered.info",
- "--rc",
- "lcov_branch_coverage=1",
- "-a",
- build_dir / "zephyr_merged.info",
- "-a",
- platform_ec / "build/coverage/lcov.info",
- ]
- log_cmd(cmd)
- subprocess.run(
- cmd,
- cwd=zephyr_dir,
- check=True,
- stdin=subprocess.DEVNULL,
- )
-
test_patterns = [
# Exclude tests
platform_ec / "test/**",
@@ -388,7 +369,7 @@ def test(opts):
"--rc",
"lcov_branch_coverage=1",
"-r",
- build_dir / "lcov_unfiltered.info",
+ build_dir / "zephyr_merged.info",
] + generated_and_system_patterns
log_cmd(cmd)
output = subprocess.run(