diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2015-11-12 10:54:19 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2015-11-12 12:37:08 -0800 |
| commit | bd83bb8f368f6b7285567090b51663b50f494671 (patch) | |
| tree | d2e70fef1fd81064fe23effad2e13eca7ae7e261 | |
| parent | 59dccac4da8c20e481c434eb9951e50d4bcd42e7 (diff) | |
| download | chrome-ec-bd83bb8f368f6b7285567090b51663b50f494671.tar.gz | |
glados/chell: drive PCH_RTCRST low
The PCH_RTCRST signal is active high controlling the gate of a FET.
Therefore, it's default state should be low.
BUG=chrome-os-partner:47505
BRANCH=None
TEST=Built. The FET is unstuffed on both boards currently.
Change-Id: Ia0e07e67e6ea4eecf151ac8890ad98c8a337c01e
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/312061
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
| -rw-r--r-- | board/chell/board.c | 2 | ||||
| -rw-r--r-- | board/chell/gpio.inc | 2 | ||||
| -rw-r--r-- | board/glados/board.c | 2 | ||||
| -rw-r--r-- | board/glados/gpio.inc | 2 |
4 files changed, 6 insertions, 2 deletions
diff --git a/board/chell/board.c b/board/chell/board.c index 1ebdc179a9..d16759d113 100644 --- a/board/chell/board.c +++ b/board/chell/board.c @@ -331,6 +331,8 @@ uint32_t board_get_gpio_hibernate_state(uint32_t port, uint32_t pin) GPIO_TO_PORT_MASK_PAIR(GPIO_USB_PD_WAKE), /* The GPIO to reset PMIC is active high */ GPIO_TO_PORT_MASK_PAIR(GPIO_PMIC_LDO_EN), + /* The GPIO to control RTCRST is active high. */ + GPIO_TO_PORT_MASK_PAIR(GPIO_PCH_RTCRST), }; /* LED GPIOs should be driven low to turn off LEDs */ diff --git a/board/chell/gpio.inc b/board/chell/gpio.inc index d63e026265..469cb1d4a6 100644 --- a/board/chell/gpio.inc +++ b/board/chell/gpio.inc @@ -54,7 +54,7 @@ GPIO(PCH_WAKE_L, PIN(66), GPIO_ODR_HIGH) GPIO(PCH_ACOK, PIN(110), GPIO_OUT_LOW) GPIO(PCH_RCIN_L, PIN(135), GPIO_ODR_HIGH) GPIO(PCH_RSMRST_L, PIN(143), GPIO_OUT_LOW) -GPIO(PCH_RTCRST, PIN(163), GPIO_INPUT | GPIO_PULL_UP) +GPIO(PCH_RTCRST, PIN(163), GPIO_OUT_LOW) GPIO(SYS_RESET_L, PIN(121), GPIO_ODR_HIGH) GPIO(ENTERING_RW, PIN(41), GPIO_OUT_LOW) diff --git a/board/glados/board.c b/board/glados/board.c index a71441bde5..0ea36b3e1e 100644 --- a/board/glados/board.c +++ b/board/glados/board.c @@ -432,6 +432,8 @@ uint32_t board_get_gpio_hibernate_state(uint32_t port, uint32_t pin) * event once we leave hibernate. */ GPIO_TO_PORT_MASK_PAIR(GPIO_USB_PD_WAKE), + /* The GPIO to control RTCRST is active high. */ + GPIO_TO_PORT_MASK_PAIR(GPIO_PCH_RTCRST), }; /* LED GPIOs should be driven low to turn off LEDs */ diff --git a/board/glados/gpio.inc b/board/glados/gpio.inc index 6427284afa..8bbc8d2801 100644 --- a/board/glados/gpio.inc +++ b/board/glados/gpio.inc @@ -111,7 +111,7 @@ GPIO(BATLOW_L_PMIC_LDO_EN, PIN(55), GPIO_INPUT) GPIO(ACCEL4_INT, PIN(157), GPIO_INPUT) GPIO(PP1800_DX_AUDIO_EN, PIN(141), GPIO_OUT_LOW) /* NC / stuffing option */ -GPIO(PCH_RTCRST, PIN(163), GPIO_INPUT | GPIO_PULL_UP) +GPIO(PCH_RTCRST, PIN(163), GPIO_OUT_LOW) GPIO(PMIC_SLP_SUS_L, PIN(201), GPIO_OUT_LOW) GPIO(USB_C1_CHARGE_EN_L, PIN(210), GPIO_OUT_LOW) |