diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-12-18 13:30:27 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-19 00:13:31 +0000 |
| commit | 2d92547fbf92eb4934e377f82de804d9dd9daa90 (patch) | |
| tree | ed4e3d84962b464e8a2738bc763186dced9d2ac2 | |
| parent | df6a65ef07f822039949454b892755e03e7ada32 (diff) | |
| download | chrome-ec-2d92547fbf92eb4934e377f82de804d9dd9daa90.tar.gz | |
Increase hook task size on x86 platforms
AP throttling in the thermal task ends up calling a pretty deep nested
set of calls, and in the worst case can overflow the stack. Bump up
the stack size for the hook task on x86 platforms to compensate.
BUG=chrome-os-partner:24536
BRANCH=peppy/falco
TEST=taskinfo shows hook task increased from 512 to 640 bytes stack
shmem shows at least 4000 bytes free
Change-Id: I63da7c47b993c935d895f91d787844655071da0d
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/180684
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
| -rw-r--r-- | board/falco/ec.tasklist | 2 | ||||
| -rw-r--r-- | board/link/ec.tasklist | 2 | ||||
| -rw-r--r-- | board/peppy/ec.tasklist | 2 | ||||
| -rw-r--r-- | board/rambi/ec.tasklist | 2 | ||||
| -rw-r--r-- | board/samus/ec.tasklist | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/board/falco/ec.tasklist b/board/falco/ec.tasklist index 3bde650552..8666f7db09 100644 --- a/board/falco/ec.tasklist +++ b/board/falco/ec.tasklist @@ -17,7 +17,7 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(VBOOTHASH, vboot_hash_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ diff --git a/board/link/ec.tasklist b/board/link/ec.tasklist index 395d068bbb..3f3d9b5015 100644 --- a/board/link/ec.tasklist +++ b/board/link/ec.tasklist @@ -17,7 +17,7 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(VBOOTHASH, vboot_hash_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(LIGHTBAR, lightbar_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ diff --git a/board/peppy/ec.tasklist b/board/peppy/ec.tasklist index 3bde650552..8666f7db09 100644 --- a/board/peppy/ec.tasklist +++ b/board/peppy/ec.tasklist @@ -17,7 +17,7 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(VBOOTHASH, vboot_hash_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ diff --git a/board/rambi/ec.tasklist b/board/rambi/ec.tasklist index 9d016bbce5..c8284ec561 100644 --- a/board/rambi/ec.tasklist +++ b/board/rambi/ec.tasklist @@ -18,7 +18,7 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(VBOOTHASH, vboot_hash_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ diff --git a/board/samus/ec.tasklist b/board/samus/ec.tasklist index 395d068bbb..3f3d9b5015 100644 --- a/board/samus/ec.tasklist +++ b/board/samus/ec.tasklist @@ -17,7 +17,7 @@ * 's' is the stack size in bytes; must be a multiple of 8 */ #define CONFIG_TASK_LIST \ - TASK_ALWAYS(HOOKS, hook_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOOKS, hook_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(VBOOTHASH, vboot_hash_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(LIGHTBAR, lightbar_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(CHARGER, charger_task, NULL, TASK_STACK_SIZE) \ |