summaryrefslogtreecommitdiff
path: root/test/tsan/Darwin
diff options
context:
space:
mode:
authorKuba Mracek <mracek@apple.com>2018-07-24 16:19:06 +0000
committerKuba Mracek <mracek@apple.com>2018-07-24 16:19:06 +0000
commit3ac94fe6137e5d5123b064b03084ea7a0bd0f5ff (patch)
tree928d2f9702196b4131370ed35a57925ebdfdd23e /test/tsan/Darwin
parent37bd9aa510166186a9bba5cf13d717d6b097c95e (diff)
downloadcompiler-rt-3ac94fe6137e5d5123b064b03084ea7a0bd0f5ff.tar.gz
[tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer
Objective-C tagged pointers (either bottom-most or top-most bit is 1) are valid Obj-C objects but are not valid pointers. Make sure we don't crash on them when used in objc_sync_enter/objc_sync_exit. Instead, let's synchronize on a global object. Differential Revision: https://reviews.llvm.org/D49707 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@337837 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/tsan/Darwin')
-rw-r--r--test/tsan/Darwin/objc-synchronize-tagged.mm62
1 files changed, 62 insertions, 0 deletions
diff --git a/test/tsan/Darwin/objc-synchronize-tagged.mm b/test/tsan/Darwin/objc-synchronize-tagged.mm
new file mode 100644
index 000000000..ab0af46ec
--- /dev/null
+++ b/test/tsan/Darwin/objc-synchronize-tagged.mm
@@ -0,0 +1,62 @@
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %run %t 2>&1 | FileCheck %s
+
+#import <Foundation/Foundation.h>
+
+NSString *tagged_string = nil;
+
+@interface MyClass : NSObject {
+ long field;
+}
+@property(nonatomic, readonly) long value;
+@end
+
+dispatch_group_t group;
+
+@implementation MyClass
+
+- (void)start {
+ dispatch_queue_t q = dispatch_queue_create(NULL, NULL);
+ dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
+ for (int i = 0; i < 10; i++) {
+ dispatch_async(q, ^{
+ @synchronized(tagged_string) {
+ self->field = i;
+ }
+ });
+ }
+ });
+}
+
+- (long)value {
+ @synchronized(tagged_string) {
+ return self->field;
+ }
+}
+
+- (void)dealloc {
+ dispatch_group_leave(group);
+}
+
+@end
+
+int main() {
+ tagged_string = [NSString stringWithFormat:@"%s", "abc"];
+ uintptr_t tagged_string_bits = (uintptr_t)tagged_string;
+ assert((tagged_string_bits & 0x8000000000000001ull) != 0);
+ group = dispatch_group_create();
+ @autoreleasepool {
+ for (int j = 0; j < 100; ++j) {
+ dispatch_group_enter(group);
+ MyClass *obj = [[MyClass alloc] init];
+ [obj start];
+ long x = obj.value;
+ (void)x;
+ }
+ }
+ dispatch_group_wait(group, DISPATCH_TIME_FOREVER);
+ NSLog(@"Hello world");
+}
+
+// CHECK: Hello world
+// CHECK-NOT: WARNING: ThreadSanitizer