summaryrefslogtreecommitdiff
path: root/test/asan/TestCases/printf-4.c
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2016-03-11 19:11:15 +0000
committerReid Kleckner <rnk@google.com>2016-03-11 19:11:15 +0000
commit5fc9856780f56688ff8617b092948443dcdade2d (patch)
tree74fbd00de73eed32471ee8e63e06ccd0956a0ab5 /test/asan/TestCases/printf-4.c
parent9c1c931a30008c919c2e674e5e4fed49a902d03f (diff)
downloadcompiler-rt-5fc9856780f56688ff8617b092948443dcdade2d.tar.gz
Make printf-4 more robust to strlen interception after r263177
The CHECK line was matching stack-buffer-overflow from puts calling strlen, which is not the bug the test is trying to catch. git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@263282 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/asan/TestCases/printf-4.c')
-rw-r--r--test/asan/TestCases/printf-4.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/test/asan/TestCases/printf-4.c b/test/asan/TestCases/printf-4.c
index 13bfc876c..d49a06ff9 100644
--- a/test/asan/TestCases/printf-4.c
+++ b/test/asan/TestCases/printf-4.c
@@ -1,10 +1,8 @@
// RUN: %clang_asan -O2 %s -o %t
-// We need replace_str=0 and replace_intrin=0 to avoid reporting errors in
-// strlen() and memcpy() called by puts().
-// RUN: %env_asan_opts=replace_str=0:replace_intrin=0:check_printf=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
-// RUN: %env_asan_opts=replace_str=0:replace_intrin=0 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
+// RUN: %env_asan_opts=check_printf=1 not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
+// RUN: not %run %t 2>&1 | FileCheck --check-prefix=CHECK-ON %s
-// FIXME: printf is not intercepted on Windows yet.
+// FIXME: sprintf is not intercepted on Windows yet.
// XFAIL: win32
#include <stdio.h>
@@ -14,10 +12,14 @@ int main() {
volatile float f = 1.239;
volatile char s[] = "34";
volatile char buf[2];
+ puts("before sprintf");
sprintf((char *)buf, "%c %d %.3f %s\n", c, x, f, s);
+ puts("after sprintf");
puts((const char *)buf);
return 0;
// Check that size of output buffer is sanitized.
+ // CHECK-ON: before sprintf
+ // CHECK-ON-NOT: after sprintf
// CHECK-ON: stack-buffer-overflow
// CHECK-ON-NOT: 0 12 1.239 34
}