diff options
author | Kostya Kortchinsky <kostyak@google.com> | 2018-09-20 14:50:06 +0000 |
---|---|---|
committer | Kostya Kortchinsky <kostyak@google.com> | 2018-09-20 14:50:06 +0000 |
commit | 3d7a4b4d1ede0d7bc644ac2370e5f7fd0924f559 (patch) | |
tree | 44e703eb0cf132270d6e1922d40bd2c182ce422b /lib | |
parent | 58a112ea742d569bf8ba7e8cde25e26b7c01db93 (diff) | |
download | compiler-rt-3d7a4b4d1ede0d7bc644ac2370e5f7fd0924f559.tar.gz |
[sanitizer] Make __sanitizer::CheckFailed not public
Summary:
As far as I can tell, there is no reason why `__sanitizer::CheckFailed` should
be exported. Looking back in time, it was added with the FIXME with the
following by @timurrrr:
```
[*San/RTL] Fix minor breakage
Grumbling: this hasn't been caught by running 'make check-{a,l,t}san check-sanitizer'
```
I can't find any detail about the breakage, all tests seem to work for me, so
maybe Windows (@rnk?) or something I have no setup for.
The reason to make it private (past the FIXME) is that Scudo defines its own
(without callback) and I am trying to make the .so be loadable with the UBsan
one (that has its own public `CheckFailed`) with as little drama as possible.
Reviewers: eugenis, rnk
Reviewed By: eugenis, rnk
Subscribers: kubamracek, delcypher, #sanitizers, timurrrr, rnk, llvm-commits
Differential Revision: https://reviews.llvm.org/D52279
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@342651 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/sanitizer_common/sanitizer_internal_defs.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/sanitizer_common/sanitizer_internal_defs.h b/lib/sanitizer_common/sanitizer_internal_defs.h index 6155a0528..34022430d 100644 --- a/lib/sanitizer_common/sanitizer_internal_defs.h +++ b/lib/sanitizer_common/sanitizer_internal_defs.h @@ -275,8 +275,6 @@ typedef thread_return_t (THREAD_CALLING_CONV *thread_callback_t)(void* arg); // NOTE: Functions below must be defined in each run-time. void NORETURN Die(); -// FIXME: No, this shouldn't be in the sanitizer interface. -SANITIZER_INTERFACE_ATTRIBUTE void NORETURN CheckFailed(const char *file, int line, const char *cond, u64 v1, u64 v2); |