diff options
Diffstat (limited to 'test/SemaObjC/comptypes-1.m')
| -rw-r--r-- | test/SemaObjC/comptypes-1.m | 81 |
1 files changed, 58 insertions, 23 deletions
diff --git a/test/SemaObjC/comptypes-1.m b/test/SemaObjC/comptypes-1.m index 997ef19c1b..9b62f97492 100644 --- a/test/SemaObjC/comptypes-1.m +++ b/test/SemaObjC/comptypes-1.m @@ -1,12 +1,12 @@ // RUN: %clang_cc1 -fsyntax-only -verify -pedantic %s #define nil (void *)0; -#define Nil (void *)0; extern void foo(); @protocol MyProtocol - (void) foo; ++ (void) bar; @end @interface MyClass @@ -22,7 +22,8 @@ int main() id<MyProtocol> obj_p = nil; MyClass *obj_c = nil; MyOtherClass *obj_cp = nil; - Class obj_C = Nil; + Class obj_C = nil; + Class<MyProtocol> obj_CP = nil; /* Assigning to an 'id' variable should never generate a warning. */ @@ -30,12 +31,15 @@ int main() obj = obj_c; /* Ok */ obj = obj_cp; /* Ok */ obj = obj_C; /* Ok */ - + obj = obj_CP; /* Ok */ + /* Assigning to a 'MyClass *' variable should always generate a warning, unless done from an 'id'. */ obj_c = obj; /* Ok */ - obj_c = obj_cp; // // expected-warning {{incompatible pointer types assigning to 'MyClass *' from 'MyOtherClass *'}} + obj_c = obj_p; // expected-warning {{assigning to 'MyClass *' from incompatible type 'id<MyProtocol>'}} + obj_c = obj_cp; // expected-warning {{incompatible pointer types assigning to 'MyClass *' from 'MyOtherClass *'}} obj_c = obj_C; // expected-warning {{incompatible pointer types assigning to 'MyClass *' from 'Class'}} + obj_c = obj_CP; // expected-warning {{incompatible pointer types assigning to 'MyClass *' from 'Class<MyProtocol>'}} /* Assigning to an 'id<MyProtocol>' variable should generate a warning if done from a 'MyClass *' (which doesn't implement @@ -45,6 +49,7 @@ int main() obj_p = obj_c; // expected-warning {{assigning to 'id<MyProtocol>' from incompatible type 'MyClass *'}} obj_p = obj_cp; /* Ok */ obj_p = obj_C; // expected-warning {{incompatible pointer types assigning to 'id<MyProtocol>' from 'Class'}} + obj_p = obj_CP; // FIXME -- should warn {{assigning to 'id<MyProtocol>' from incompatible type 'Class<MyProtocol>'}} /* Assigning to a 'MyOtherClass *' variable should always generate a warning, unless done from an 'id' or an 'id<MyProtocol>' (since @@ -53,37 +58,67 @@ int main() obj_cp = obj_c; // expected-warning {{incompatible pointer types assigning to 'MyOtherClass *' from 'MyClass *'}} obj_cp = obj_p; /* Ok */ obj_cp = obj_C; // expected-warning {{incompatible pointer types assigning to 'MyOtherClass *' from 'Class'}} + obj_cp = obj_CP; // expected-warning {{incompatible pointer types assigning to 'MyOtherClass *' from 'Class<MyProtocol>'}} + + obj_C = obj; // Ok + obj_C = obj_p; // expected-warning {{incompatible pointer types assigning to 'Class' from 'id<MyProtocol>'}} + obj_C = obj_c; // expected-warning {{incompatible pointer types assigning to 'Class' from 'MyClass *'}} + obj_C = obj_cp; // expected-warning {{incompatible pointer types assigning to 'Class' from 'MyOtherClass *'}} + obj_C = obj_CP; // Ok + + obj_CP = obj; // Ok + obj_CP = obj_p; // expected-warning {{assigning to 'Class<MyProtocol>' from incompatible type 'id<MyProtocol>'}} + obj_CP = obj_c; // expected-warning {{incompatible pointer types assigning to 'Class<MyProtocol>' from 'MyClass *}} + obj_CP = obj_cp; // expected-warning {{incompatible pointer types assigning to 'Class<MyProtocol>' from 'MyOtherClass *'}} + obj_CP = obj_C; // Ok /* Any comparison involving an 'id' must be without warnings. */ - if (obj == obj_p) foo() ; /* Ok */ /*Bogus warning here in 2.95.4*/ - if (obj_p == obj) foo() ; /* Ok */ - if (obj == obj_c) foo() ; /* Ok */ - if (obj_c == obj) foo() ; /* Ok */ - if (obj == obj_cp) foo() ; /* Ok */ - if (obj_cp == obj) foo() ; /* Ok */ - if (obj == obj_C) foo() ; /* Ok */ - if (obj_C == obj) foo() ; /* Ok */ + if (obj == obj_p) foo(); /* Ok */ /*Bogus warning here in 2.95.4*/ + if (obj_p == obj) foo(); /* Ok */ + if (obj == obj_c) foo(); /* Ok */ + if (obj_c == obj) foo(); /* Ok */ + if (obj == obj_cp) foo(); /* Ok */ + if (obj_cp == obj) foo(); /* Ok */ + if (obj == obj_C) foo(); /* Ok */ + if (obj_C == obj) foo(); /* Ok */ + if (obj == obj_CP) foo(); /* Ok */ + if (obj_CP == obj) foo(); /* Ok */ /* Any comparison between 'MyClass *' and anything which is not an 'id' must generate a warning. */ - if (obj_p == obj_c) foo() ; // expected-warning {{comparison of distinct pointer types ('id<MyProtocol>' and 'MyClass *')}} + if (obj_c == obj_p) foo(); // expected-warning {{comparison of distinct pointer types ('MyClass *' and 'id<MyProtocol>')}} + if (obj_p == obj_c) foo(); // expected-warning {{comparison of distinct pointer types ('id<MyProtocol>' and 'MyClass *')}} + + if (obj_c == obj_cp) foo(); // expected-warning {{comparison of distinct pointer types ('MyClass *' and 'MyOtherClass *')}} + if (obj_cp == obj_c) foo(); // expected-warning {{comparison of distinct pointer types ('MyOtherClass *' and 'MyClass *')}} - if (obj_c == obj_cp) foo() ; // expected-warning {{comparison of distinct pointer types ('MyClass *' and 'MyOtherClass *')}} - if (obj_cp == obj_c) foo() ; // expected-warning {{comparison of distinct pointer types ('MyOtherClass *' and 'MyClass *')}} + if (obj_c == obj_C) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('MyClass *' and 'Class')}} + if (obj_C == obj_c) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('Class' and 'MyClass *')}} - if (obj_c == obj_C) foo() ; - if (obj_C == obj_c) foo() ; + if (obj_c == obj_CP) foo(); // expected-warning {{comparison of distinct pointer types ('MyClass *' and 'Class<MyProtocol>')}} + if (obj_CP == obj_c) foo(); // expected-warning {{comparison of distinct pointer types ('Class<MyProtocol>' and 'MyClass *')}} /* Any comparison between 'MyOtherClass *' (which implements MyProtocol) and an 'id' implementing MyProtocol are Ok. */ - if (obj_cp == obj_p) foo() ; /* Ok */ - if (obj_p == obj_cp) foo() ; /* Ok */ + if (obj_p == obj_cp) foo(); /* Ok */ + if (obj_cp == obj_p) foo(); /* Ok */ + + if (obj_p == obj_C) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('id<MyProtocol>' and 'Class')}} + if (obj_C == obj_p) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('Class' and 'id<MyProtocol>')}} + + if (obj_p == obj_CP) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('id<MyProtocol>' and 'Class<MyProtocol>')}} + if (obj_CP == obj_p) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('Class<MyProtocol>' and 'id<MyProtocol>')}} + + /* Comparisons between MyOtherClass * and Class types is a warning */ + if (obj_cp == obj_C) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('MyOtherClass *' and 'Class')}} + if (obj_C == obj_cp) foo(); // FIXME -- should warn {{comparison of distinct pointer types ('Class' and 'MyOtherClass *')}} + if (obj_cp == obj_CP) foo(); // expected-warning {{comparison of distinct pointer types ('MyOtherClass *' and 'Class<MyProtocol>')}} + if (obj_CP == obj_cp) foo(); // expected-warning {{comparison of distinct pointer types ('Class<MyProtocol>' and 'MyOtherClass *')}} - if (obj_p == obj_C) foo() ; - if (obj_C == obj_p) foo() ; - if (obj_cp == obj_C) foo() ; - if (obj_C == obj_cp) foo() ; + /* Comparisons between a Class and a Class<MyProtocol> are ok */ + if (obj_C == obj_CP) foo(); /* Ok */ + if (obj_CP == obj_C) foo(); /* Ok */ return 0; } |