diff options
author | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2019-08-29 23:14:08 +0000 |
---|---|---|
committer | Bruno Cardoso Lopes <bruno.cardoso@gmail.com> | 2019-08-29 23:14:08 +0000 |
commit | d6beacf5d7933083d3a3102102d3d8b379288aa5 (patch) | |
tree | c9958cd46fa7727b359fda05edd396594a9abd1d /tools | |
parent | b27d7164069510c464647b838b41327bd5257d4d (diff) | |
download | clang-d6beacf5d7933083d3a3102102d3d8b379288aa5.tar.gz |
[Modules] Make ReadModuleMapFileBlock errors reliable
This prevents a crash when an error should be emitted instead.
During implicit module builds, there are cases where ReadASTCore is called with
ImportedBy set to nullptr, which breaks expectations in ReadModuleMapFileBlock,
leading to crashes.
Fix this by improving ReadModuleMapFileBlock to handle ImportedBy correctly.
This only happens non deterministically in the wild, when the underlying file
system changes while concurrent compiler invocations use implicit modules,
forcing rebuilds which see an inconsistent filesystem state. That said, there's
no much to do w.r.t. writing tests here.
rdar://problem/48828801
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@370422 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions