diff options
| author | Kuba Mracek <mracek@apple.com> | 2017-08-15 19:47:06 +0000 |
|---|---|---|
| committer | Kuba Mracek <mracek@apple.com> | 2017-08-15 19:47:06 +0000 |
| commit | d9232a8d2393a568d1e6732eefe09996df5f3cbd (patch) | |
| tree | 075c6f329229809ce7ee4b1fa2de829283775ab0 /test/Driver/ps4-linker-non-win.c | |
| parent | 709ce01f5878ac12902d0b31d363ccd5a31fae74 (diff) | |
| download | clang-d9232a8d2393a568d1e6732eefe09996df5f3cbd.tar.gz | |
[clang] Get rid of "%T" expansions
The %T lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests. In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban %T and only keep %t, which is unique to each test. When a test needs a temporary directory, it can just create one using mkdir %t.
This patch removes %T in clang.
Differential Revision: https://reviews.llvm.org/D36437
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@310950 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Driver/ps4-linker-non-win.c')
| -rw-r--r-- | test/Driver/ps4-linker-non-win.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/test/Driver/ps4-linker-non-win.c b/test/Driver/ps4-linker-non-win.c index e2f8386b2c..3197292176 100644 --- a/test/Driver/ps4-linker-non-win.c +++ b/test/Driver/ps4-linker-non-win.c @@ -1,21 +1,21 @@ // UNSUPPORTED: system-windows // REQUIRES: x86-registered-target -// RUN: mkdir -p %T/Output -// RUN: rm -f %T/Output/orbis-ld -// RUN: touch %T/Output/orbis-ld -// RUN: chmod +x %T/Output/orbis-ld +// RUN: mkdir -p %t +// RUN: rm -f %t/orbis-ld +// RUN: touch %t/orbis-ld +// RUN: chmod +x %t/orbis-ld -// RUN: env "PATH=%T/Output:%PATH%" %clang -### -target x86_64-scei-ps4 %s -fuse-ld=gold 2>&1 \ +// RUN: env "PATH=%t:%PATH%" %clang -### -target x86_64-scei-ps4 %s -fuse-ld=gold 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PS4-LINKER %s -// RUN: env "PATH=%T/Output:%PATH%" %clang -### -target x86_64-scei-ps4 %s -shared 2>&1 \ +// RUN: env "PATH=%t:%PATH%" %clang -### -target x86_64-scei-ps4 %s -shared 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PS4-LINKER %s -// RUN: env "PATH=%T/Output:%PATH%" %clang -### -target x86_64-scei-ps4 %s 2>&1 \ +// RUN: env "PATH=%t:%PATH%" %clang -### -target x86_64-scei-ps4 %s 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PS4-LINKER %s -// RUN: env "PATH=%T/Output:%PATH%" %clang -### -target x86_64-scei-ps4 %s -fuse-ld=ps4 2>&1 \ +// RUN: env "PATH=%t:%PATH%" %clang -### -target x86_64-scei-ps4 %s -fuse-ld=ps4 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PS4-LINKER %s -// RUN: env "PATH=%T/Output:%PATH%" %clang -### -target x86_64-scei-ps4 %s -shared \ +// RUN: env "PATH=%t:%PATH%" %clang -### -target x86_64-scei-ps4 %s -shared \ // RUN: -fuse-ld=ps4 2>&1 | FileCheck --check-prefix=CHECK-PS4-LINKER %s // CHECK-PS4-LINKER: /orbis-ld |