diff options
| author | Hans Wennborg <hans@hanshq.net> | 2019-09-05 08:43:00 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2019-09-05 08:43:00 +0000 |
| commit | 7912f726e011211909dd4f85407f6b05a9e393d2 (patch) | |
| tree | 1c22603865f9ca9fc7cd7acdc5c7ff2242415d70 /test/Driver/gen-cdb-fragment.c | |
| parent | 62f62fd3e1b269e0b05fe419fa64e70c255e9179 (diff) | |
| download | clang-7912f726e011211909dd4f85407f6b05a9e393d2.tar.gz | |
Revert r361885 "[Driver] Fix -working-directory issues"
This made clang unable to open files using relative paths on network shares on
Windows (PR43204). On the bug it was pointed out that createPhysicalFileSystem()
is not terribly mature, and using it is risky. Reverting for now until there's
a clear way forward.
> Currently the `-working-directory` option does not actually impact the working
> directory for all of the clang driver, it only impacts how files are looked up
> to make sure they exist. This means that that clang passes the wrong paths
> to -fdebug-compilation-dir and -coverage-notes-file.
>
> This patch fixes that by changing all the places in the driver where we convert
> to absolute paths to use the VFS, and then calling setCurrentWorkingDirectory on
> the VFS. This also changes the default VFS for `Driver` to use a virtualized
> working directory, instead of changing the process's working directory.
>
> Differential Revision: https://reviews.llvm.org/D62271
This also revertes the part of r369938 which checked that -working-directory works.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@371027 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Driver/gen-cdb-fragment.c')
| -rw-r--r-- | test/Driver/gen-cdb-fragment.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/test/Driver/gen-cdb-fragment.c b/test/Driver/gen-cdb-fragment.c index 41d69894a7..f12a0e018d 100644 --- a/test/Driver/gen-cdb-fragment.c +++ b/test/Driver/gen-cdb-fragment.c @@ -15,14 +15,6 @@ // RUN: %clang -target x86_64-apple-macos10.15 -S %s -o - -gen-cdb-fragment-path %t.cdb // RUN: ls %t.cdb | FileCheck --check-prefix=CHECK-LS %s -// Working directory arg is respected. -// RUN: rm -rf %t.cdb -// RUN: mkdir %t.cdb -// RUN: %clang -target x86_64-apple-macos10.15 -working-directory %t.cdb -c %s -o - -gen-cdb-fragment-path "." -// RUN: ls %t.cdb | FileCheck --check-prefix=CHECK-LS %s -// RUN: cat %t.cdb/*.json | FileCheck --check-prefix=CHECK-CWD %s -// CHECK-CWD: "directory": "{{.*}}.cdb" - // -### does not emit the CDB fragment // RUN: rm -rf %t.cdb // RUN: mkdir %t.cdb |