summaryrefslogtreecommitdiff
path: root/test/CXX
diff options
context:
space:
mode:
authorLeonard Chan <leonardchan@google.com>2019-09-04 20:30:29 +0000
committerLeonard Chan <leonardchan@google.com>2019-09-04 20:30:29 +0000
commit3c6ee3dacaccb1f818db5d8b9a6169d2d116e7aa (patch)
treee71edd11cd4a8aec51b63a1501d709a1d6e637d4 /test/CXX
parent9ff46a3fe18a95a18b540a5f448bf6f8ad1e7912 (diff)
downloadclang-3c6ee3dacaccb1f818db5d8b9a6169d2d116e7aa.tar.gz
[NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes
This patch merges the sancov module and funciton passes into one module pass. The reason for this is because we ran into an out of memory error when attempting to run asan fuzzer on some protobufs (pc.cc files). I traced the OOM error to the destructor of SanitizerCoverage where we only call appendTo[Compiler]Used which calls appendToUsedList. I'm not sure where precisely in appendToUsedList causes the OOM, but I am able to confirm that it's calling this function *repeatedly* that causes the OOM. (I hacked sancov a bit such that I can still create and destroy a new sancov on every function run, but only call appendToUsedList after all functions in the module have finished. This passes, but when I make it such that appendToUsedList is called on every sancov destruction, we hit OOM.) I don't think the OOM is from just adding to the SmallSet and SmallVector inside appendToUsedList since in either case for a given module, they'll have the same max size. I suspect that when the existing llvm.compiler.used global is erased, the memory behind it isn't freed. I could be wrong on this though. This patch works around the OOM issue by just calling appendToUsedList at the end of every module run instead of function run. The same amount of constants still get added to llvm.compiler.used, abd we make the pass usage and logic simpler by not having any inter-pass dependencies. Differential Revision: https://reviews.llvm.org/D66988 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@370971 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/CXX')
0 files changed, 0 insertions, 0 deletions