diff options
author | Eric Christopher <echristo@gmail.com> | 2019-10-14 23:14:24 +0000 |
---|---|---|
committer | Eric Christopher <echristo@gmail.com> | 2019-10-14 23:14:24 +0000 |
commit | b1f59aa74b4bb084f6e1a11e10ae77187cd999b0 (patch) | |
tree | 0bfd3c73c8b71e94cb955a95850647c5e832dfe0 /include | |
parent | 779f672417bab6e2329d3135fc3d83a8bfd9f705 (diff) | |
download | clang-b1f59aa74b4bb084f6e1a11e10ae77187cd999b0.tar.gz |
Temporarily Revert [Modules][PCH] Hash input files content
as it's breaking a few bots.
This reverts r374841 (git commit 2a1386c81de504b5bda44fbecf3f7b4cdfd748fc)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@374842 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include')
-rw-r--r-- | include/clang/Basic/DiagnosticSerializationKinds.td | 11 | ||||
-rw-r--r-- | include/clang/Driver/Options.td | 22 | ||||
-rw-r--r-- | include/clang/Lex/HeaderSearchOptions.h | 7 | ||||
-rw-r--r-- | include/clang/Serialization/ASTBitCodes.h | 5 | ||||
-rw-r--r-- | include/clang/Serialization/ASTReader.h | 10 |
5 files changed, 6 insertions, 49 deletions
diff --git a/include/clang/Basic/DiagnosticSerializationKinds.td b/include/clang/Basic/DiagnosticSerializationKinds.td index 757dbbeee3..0461d2f429 100644 --- a/include/clang/Basic/DiagnosticSerializationKinds.td +++ b/include/clang/Basic/DiagnosticSerializationKinds.td @@ -18,16 +18,13 @@ def err_fe_pch_malformed : Error< def err_fe_pch_malformed_block : Error< "malformed block record in PCH file: '%0'">, DefaultFatal; def err_fe_pch_file_modified : Error< - "file '%0' has been modified since the precompiled header '%1' was built" - ": %select{size|mtime|content}2 changed">, + "file '%0' has been modified since the precompiled header '%1' was built">, DefaultFatal; def err_fe_module_file_modified : Error< - "file '%0' has been modified since the module file '%1' was built" - ": %select{size|mtime|content}2 changed">, + "file '%0' has been modified since the module file '%1' was built">, DefaultFatal; def err_fe_ast_file_modified : Error< - "file '%0' has been modified since the AST file '%1' was built" - ": %select{size|mtime|content}2 changed">, + "file '%0' has been modified since the AST file '%1' was built">, DefaultFatal; def err_fe_pch_file_overridden : Error< "file '%0' from the precompiled header has been overridden">; @@ -402,8 +399,6 @@ def warn_module_uses_date_time : Warning< def err_module_no_size_mtime_for_header : Error< "cannot emit module %0: %select{size|mtime}1 must be explicitly specified " "for missing header file \"%2\"">; -def err_module_unable_to_hash_content : Error< - "failed to hash content for '%0' because memory buffer cannot be retrieved">; } // let CategoryName } // let Component diff --git a/include/clang/Driver/Options.td b/include/clang/Driver/Options.td index 3ce6fcf29f..22676b6787 100644 --- a/include/clang/Driver/Options.td +++ b/include/clang/Driver/Options.td @@ -1368,28 +1368,6 @@ def fmodules_validate_system_headers : Flag<["-"], "fmodules-validate-system-hea HelpText<"Validate the system headers that a module depends on when loading the module">; def fno_modules_validate_system_headers : Flag<["-"], "fno-modules-validate-system-headers">, Group<i_Group>, Flags<[DriverOption]>; - -def fvalidate_ast_input_files_content: - Flag <["-"], "fvalidate-ast-input-files-content">, - Group<f_Group>, Flags<[CC1Option]>, - HelpText<"Compute and store the hash of input files used to build an AST." - " Files with mismatching mtime's are considered valid" - " if both contents is identical">; -def fmodules_validate_input_files_content: - Flag <["-"], "fmodules-validate-input-files-content">, - Group<f_Group>, Flags<[DriverOption]>, - HelpText<"Validate PCM input files based on content if mtime differs">; -def fno_modules_validate_input_files_content: - Flag <["-"], "fno_modules-validate-input-files-content">, - Group<f_Group>, Flags<[DriverOption]>; -def fpch_validate_input_files_content: - Flag <["-"], "fpch-validate-input-files-content">, - Group<f_Group>, Flags<[DriverOption]>, - HelpText<"Validate PCH input files based on content if mtime differs">; -def fno_pch_validate_input_files_content: - Flag <["-"], "fno_pch-validate-input-files-content">, - Group<f_Group>, Flags<[DriverOption]>; - def fmodules : Flag <["-"], "fmodules">, Group<f_Group>, Flags<[DriverOption, CC1Option]>, HelpText<"Enable the 'modules' language feature">; diff --git a/include/clang/Lex/HeaderSearchOptions.h b/include/clang/Lex/HeaderSearchOptions.h index 3c309744ba..ed128bce48 100644 --- a/include/clang/Lex/HeaderSearchOptions.h +++ b/include/clang/Lex/HeaderSearchOptions.h @@ -195,10 +195,6 @@ public: /// Whether to validate system input files when a module is loaded. unsigned ModulesValidateSystemHeaders : 1; - // Whether the content of input files should be hashed and used to - // validate consistency. - unsigned ValidateASTInputFilesContent : 1; - /// Whether the module includes debug information (-gmodules). unsigned UseDebugInfo : 1; @@ -212,8 +208,7 @@ public: UseBuiltinIncludes(true), UseStandardSystemIncludes(true), UseStandardCXXIncludes(true), UseLibcxx(false), Verbose(false), ModulesValidateOncePerBuildSession(false), - ModulesValidateSystemHeaders(false), - ValidateASTInputFilesContent(false), UseDebugInfo(false), + ModulesValidateSystemHeaders(false), UseDebugInfo(false), ModulesValidateDiagnosticOptions(true), ModulesHashContent(false) {} /// AddPath - Add the \p Path path to the specified \p Group list. diff --git a/include/clang/Serialization/ASTBitCodes.h b/include/clang/Serialization/ASTBitCodes.h index eab1ec86db..94721f9fd3 100644 --- a/include/clang/Serialization/ASTBitCodes.h +++ b/include/clang/Serialization/ASTBitCodes.h @@ -382,10 +382,7 @@ namespace serialization { /// inside the control block. enum InputFileRecordTypes { /// An input file. - INPUT_FILE = 1, - - /// The input file content hash - INPUT_FILE_HASH + INPUT_FILE = 1 }; /// Record types that occur within the AST block itself. diff --git a/include/clang/Serialization/ASTReader.h b/include/clang/Serialization/ASTReader.h index 7495c2b17a..13d16539cc 100644 --- a/include/clang/Serialization/ASTReader.h +++ b/include/clang/Serialization/ASTReader.h @@ -930,9 +930,6 @@ private: /// Whether validate system input files. bool ValidateSystemInputs; - /// Whether validate headers and module maps using hash based on contents. - bool ValidateASTInputFilesContent; - /// Whether we are allowed to use the global module index. bool UseGlobalIndex; @@ -1206,7 +1203,6 @@ private: struct InputFileInfo { std::string Filename; - uint64_t ContentHash; off_t StoredSize; time_t StoredTime; bool Overridden; @@ -1441,8 +1437,6 @@ private: void Error(StringRef Msg) const; void Error(unsigned DiagID, StringRef Arg1 = StringRef(), StringRef Arg2 = StringRef()) const; - void Error(unsigned DiagID, StringRef Arg1, StringRef Arg2, - unsigned Select) const; void Error(llvm::Error &&Err) const; public: @@ -1491,9 +1485,7 @@ public: StringRef isysroot = "", bool DisableValidation = false, bool AllowASTWithCompilerErrors = false, bool AllowConfigurationMismatch = false, - bool ValidateSystemInputs = false, - bool ValidateASTInputFilesContent = false, - bool UseGlobalIndex = true, + bool ValidateSystemInputs = false, bool UseGlobalIndex = true, std::unique_ptr<llvm::Timer> ReadTimer = {}); ASTReader(const ASTReader &) = delete; ASTReader &operator=(const ASTReader &) = delete; |