diff options
| author | Zhizhou Yang <zhizhouyang@gmail.com> | 2018-11-29 18:52:22 +0000 |
|---|---|---|
| committer | Zhizhou Yang <zhizhouyang@gmail.com> | 2018-11-29 18:52:22 +0000 |
| commit | e030444510df2ffaf23eeae35692dc363bc28439 (patch) | |
| tree | fd61c2ed360f7ff0536d2c357799009c755d1d6c | |
| parent | 3eda68cb72ca6b1636edc9346de4ab57b32ba679 (diff) | |
| download | clang-e030444510df2ffaf23eeae35692dc363bc28439.tar.gz | |
set default max-page-size to 4KB in lld for Android Aarch64
Summary:
This patch passes an option '-z max-page-size=4096' to lld through clang driver.
This is for Android on Aarch64 target.
The lld default page size is too large for Aarch64, which produces larger .so files and images for arm64 device targets.
In this patch we set default page size to 4KB for Android Aarch64 targets instead.
Reviewers: srhines, danalbert, ruiu, chh, peter.smith
Reviewed By: srhines
Subscribers: javed.absar, kristof.beyls, cfe-commits, george.burgess.iv, llozano
Differential Revision: https://reviews.llvm.org/D55029
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@347897 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Driver/ToolChains/Linux.cpp | 8 | ||||
| -rw-r--r-- | test/Driver/android-aarch64-link.cpp | 5 |
2 files changed, 13 insertions, 0 deletions
diff --git a/lib/Driver/ToolChains/Linux.cpp b/lib/Driver/ToolChains/Linux.cpp index 79deb04f97..65ab9b2daf 100644 --- a/lib/Driver/ToolChains/Linux.cpp +++ b/lib/Driver/ToolChains/Linux.cpp @@ -247,6 +247,14 @@ Linux::Linux(const Driver &D, const llvm::Triple &Triple, const ArgList &Args) ExtraOpts.push_back("relro"); } + // The lld default page size is too large for Aarch64, which produces much + // larger .so files and images for arm64 device targets. Use 4KB page size + // for Android arm64 targets instead. + if (Triple.isAArch64() && Triple.isAndroid()) { + ExtraOpts.push_back("-z"); + ExtraOpts.push_back("max-page-size=4096"); + } + if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") != StringRef::npos) // With devtoolset on RHEL, we want to add a bin directory that is relative diff --git a/test/Driver/android-aarch64-link.cpp b/test/Driver/android-aarch64-link.cpp index 2c4cfb9898..051bcd57b1 100644 --- a/test/Driver/android-aarch64-link.cpp +++ b/test/Driver/android-aarch64-link.cpp @@ -12,6 +12,11 @@ // RUN: -mcpu=cortex-a57 -### -v %s 2> %t // RUN: FileCheck -check-prefix=CORTEX-A57 < %t %s // +// RUN: %clang -target aarch64-none-linux-android \ +// RUN: -### -v %s 2> %t +// RUN: FileCheck -check-prefix=MAX-PAGE-SIZE < %t %s +// // GENERIC-ARM: --fix-cortex-a53-843419 // CORTEX-A53: --fix-cortex-a53-843419 // CORTEX-A57-NOT: --fix-cortex-a53-843419 +// MAX-PAGE-SIZE: max-page-size=4096 |