diff options
author | Yitzhak Mandelbaum <yitzhakm@google.com> | 2019-10-16 14:26:20 +0000 |
---|---|---|
committer | Yitzhak Mandelbaum <yitzhakm@google.com> | 2019-10-16 14:26:20 +0000 |
commit | 9db088e09ee7d5574b0fb4086d9258e9fb062c42 (patch) | |
tree | fcd6d6e4da30e94b9f819ad0bfb7863524543a08 | |
parent | d87cdd38be750b613bb8c68174e4eaca23a6084a (diff) | |
download | clang-9db088e09ee7d5574b0fb4086d9258e9fb062c42.tar.gz |
[libTooling] Fix r374962: add more Transformer forwarding decls.
Summary:
The move to a new, single namespace in r374962 left out some type definitions
from the old namespace and resulted in one naming conflict (`text`). This
revision adds aliases for those definitions and removes one of the `text`
functions from the new namespace.
Reviewers: alexfh
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69036
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@375003 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/clang/Tooling/Transformer/RangeSelector.h | 2 | ||||
-rw-r--r-- | include/clang/Tooling/Transformer/RewriteRule.h | 18 | ||||
-rw-r--r-- | include/clang/Tooling/Transformer/Stencil.h | 4 | ||||
-rw-r--r-- | unittests/Tooling/TransformerTest.cpp | 1 |
4 files changed, 16 insertions, 9 deletions
diff --git a/include/clang/Tooling/Transformer/RangeSelector.h b/include/clang/Tooling/Transformer/RangeSelector.h index 00f1f84d0f..9f556d2063 100644 --- a/include/clang/Tooling/Transformer/RangeSelector.h +++ b/include/clang/Tooling/Transformer/RangeSelector.h @@ -92,6 +92,8 @@ RangeSelector expansion(RangeSelector S); namespace tooling { // DEPRECATED: These are temporary aliases supporting client migration to the // `transformer` namespace. +using RangeSelector = transformer::RangeSelector; + using transformer::after; using transformer::before; using transformer::callArgs; diff --git a/include/clang/Tooling/Transformer/RewriteRule.h b/include/clang/Tooling/Transformer/RewriteRule.h index 058ef3f23d..6e99151c1c 100644 --- a/include/clang/Tooling/Transformer/RewriteRule.h +++ b/include/clang/Tooling/Transformer/RewriteRule.h @@ -31,11 +31,6 @@ namespace clang { namespace transformer { using TextGenerator = MatchConsumer<std::string>; -/// Wraps a string as a TextGenerator. -inline TextGenerator text(std::string M) { - return [M](const ast_matchers::MatchFinder::MatchResult &) - -> Expected<std::string> { return M; }; -} // Description of a source-code edit, expressed in terms of an AST node. // Includes: an ID for the (bound) node, a selector for source related to the @@ -221,7 +216,9 @@ inline ASTEdit insertAfter(RangeSelector S, TextGenerator Replacement) { /// Removes the source selected by \p S. inline ASTEdit remove(RangeSelector S) { - return change(std::move(S), text("")); + return change(std::move(S), + [](const ast_matchers::MatchFinder::MatchResult &) + -> Expected<std::string> { return ""; }); } /// The following three functions are a low-level part of the RewriteRule @@ -286,6 +283,14 @@ translateEdits(const ast_matchers::MatchFinder::MatchResult &Result, namespace tooling { // DEPRECATED: These are temporary aliases supporting client migration to the // `transformer` namespace. +/// Wraps a string as a TextGenerator. +using TextGenerator = transformer::TextGenerator; + +inline TextGenerator text(std::string M) { + return [M](const ast_matchers::MatchFinder::MatchResult &) + -> Expected<std::string> { return M; }; +} + using transformer::addInclude; using transformer::applyFirst; using transformer::change; @@ -293,7 +298,6 @@ using transformer::insertAfter; using transformer::insertBefore; using transformer::makeRule; using transformer::remove; -using transformer::text; using transformer::RewriteRule; using transformer::IncludeFormat; namespace detail { diff --git a/include/clang/Tooling/Transformer/Stencil.h b/include/clang/Tooling/Transformer/Stencil.h index feb3ac8853..66d1388f97 100644 --- a/include/clang/Tooling/Transformer/Stencil.h +++ b/include/clang/Tooling/Transformer/Stencil.h @@ -195,9 +195,11 @@ StencilPart dPrint(llvm::StringRef Id); } // namespace transformer namespace tooling { -namespace stencil { // DEPRECATED: These are temporary aliases supporting client migration to the // `transformer` namespace. +using Stencil = transformer::Stencil; +using StencilPart = transformer::StencilPart; +namespace stencil { using transformer::access; using transformer::addressOf; using transformer::cat; diff --git a/unittests/Tooling/TransformerTest.cpp b/unittests/Tooling/TransformerTest.cpp index c42976a71c..ee05b74c1a 100644 --- a/unittests/Tooling/TransformerTest.cpp +++ b/unittests/Tooling/TransformerTest.cpp @@ -21,7 +21,6 @@ using namespace ast_matchers; namespace { using ::testing::IsEmpty; using transformer::RewriteRule; -using transformer::text; constexpr char KHeaderContents[] = R"cc( struct string { |