diff options
| author | Ilya Biryukov <ibiryukov@google.com> | 2019-02-01 11:20:13 +0000 |
|---|---|---|
| committer | Ilya Biryukov <ibiryukov@google.com> | 2019-02-01 11:20:13 +0000 |
| commit | 56d19413a8096b021bece8d17f87948bf69d213c (patch) | |
| tree | a274b8a3fba4e99897bbe207f00732ffbf007da9 /.clang-tidy | |
| parent | 07d269d2686e28ea49aaa43338db962b084adce3 (diff) | |
| download | clang-56d19413a8096b021bece8d17f87948bf69d213c.tar.gz | |
Disable tidy checks with too many hits
Summary:
Some tidy checks have too many hits in the codebase, making it hard to spot
other results from clang-tidy, therefore rendering the tool less useful.
Two checks were disabled:
- misc-non-private-member-variable-in-classes in the whole LLVM monorepo,
it is very common to have those in LLVM and the style guide does not forbid
them.
- readability-identifier-naming in the clang subtree. There are thousands of
violations in 'Sema.h' alone.
Before the change, 'Sema.h' had >1000 tidy warnings, after the change the number
dropped to 3 warnings (unterminated namespace comments).
Reviewers: alexfh, hokein
Reviewed By: hokein
Subscribers: llvm-commits, cfe-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D57573
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@352862 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to '.clang-tidy')
| -rw-r--r-- | .clang-tidy | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/.clang-tidy b/.clang-tidy index 2cfcc2ac22..849c26987e 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,4 +1,9 @@ -Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming' +Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming' +# Note that the readability-identifier-naming check is disabled, there are too +# many violations in the codebase and they create too much noise in clang-tidy +# results. +# Naming settings are kept for documentation purposes and allowing to run the +# check if the users would override this file, e.g. via a command-line arg. CheckOptions: - key: readability-identifier-naming.ClassCase value: CamelCase |