summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2020-01-22 10:37:09 +0100
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2020-01-22 10:47:24 +0100
commit19b76473a28b3e392c7acdfa7503f68d96702f24 (patch)
treeb737a8707b12f5b56a80b2c6a475b8bb1e592425
parent12b786888e630a6141273d28b74ec4b2e075cc44 (diff)
downloadbundler-test/more_windows_improvements.tar.gz
Trigger all current failurestest/more_windows_improvements
-rw-r--r--.github/workflows/windows.yml1
-rw-r--r--spec/bundler/cli_spec.rb1
-rw-r--r--spec/bundler/env_spec.rb2
-rw-r--r--spec/bundler/mirror_spec.rb1
-rw-r--r--spec/commands/binstubs_spec.rb2
-rw-r--r--spec/commands/cache_spec.rb1
-rw-r--r--spec/commands/exec_spec.rb12
-rw-r--r--spec/commands/help_spec.rb1
-rw-r--r--spec/commands/install_spec.rb2
-rw-r--r--spec/install/allow_offline_install_spec.rb3
-rw-r--r--spec/install/deploy_spec.rb2
-rw-r--r--spec/install/gemfile/gemspec_spec.rb1
-rw-r--r--spec/install/gemfile/git_spec.rb6
-rw-r--r--spec/install/gemfile/path_spec.rb3
-rw-r--r--spec/install/gemfile/platform_spec.rb3
-rw-r--r--spec/install/gems/compact_index_spec.rb50
-rw-r--r--spec/install/gems/dependency_api_spec.rb39
-rw-r--r--spec/install/gems/resolving_spec.rb3
-rw-r--r--spec/install/gems/standalone_spec.rb4
-rw-r--r--spec/install/gemspecs_spec.rb1
-rw-r--r--spec/install/git_spec.rb1
-rw-r--r--spec/install/global_cache_spec.rb4
-rw-r--r--spec/lock/lockfile_spec.rb2
-rw-r--r--spec/runtime/executable_spec.rb9
-rw-r--r--spec/runtime/inline_spec.rb2
-rw-r--r--spec/runtime/require_spec.rb1
-rw-r--r--spec/runtime/setup_spec.rb3
-rw-r--r--spec/runtime/with_unbundled_env_spec.rb5
-rw-r--r--spec/support/helpers.rb2
29 files changed, 1 insertions, 166 deletions
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 00e0fc0385..9274224adc 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -7,6 +7,7 @@ on:
branches:
- staging
- trying
+ - test/more_windows_improvements
jobs:
windows:
diff --git a/spec/bundler/cli_spec.rb b/spec/bundler/cli_spec.rb
index 561f471687..e2085640a9 100644
--- a/spec/bundler/cli_spec.rb
+++ b/spec/bundler/cli_spec.rb
@@ -14,7 +14,6 @@ RSpec.describe "bundle executable" do
end
it "looks for a binary and executes it if it's named bundler-<task>" do
- skip "obscure error" if Gem.win_platform?
File.open(tmp("bundler-testtasks"), "w", 0o755) do |f|
ruby = ENV["RUBY"] || "/usr/bin/env ruby"
diff --git a/spec/bundler/env_spec.rb b/spec/bundler/env_spec.rb
index 8ff5ddada6..a4828f7f3d 100644
--- a/spec/bundler/env_spec.rb
+++ b/spec/bundler/env_spec.rb
@@ -34,7 +34,6 @@ RSpec.describe Bundler::Env do
end
it "prints user home" do
- skip "needs to use a valid HOME" if Gem.win_platform? && RUBY_VERSION < "2.6.0"
with_clear_paths("HOME", "/a/b/c") do
out = described_class.report
@@ -43,7 +42,6 @@ RSpec.describe Bundler::Env do
end
it "prints user path" do
- skip "needs to use a valid HOME" if Gem.win_platform? && RUBY_VERSION < "2.6.0"
with_clear_paths("HOME", "/a/b/c") do
out = described_class.report
diff --git a/spec/bundler/mirror_spec.rb b/spec/bundler/mirror_spec.rb
index 1eaf1e9a8e..9b226b1797 100644
--- a/spec/bundler/mirror_spec.rb
+++ b/spec/bundler/mirror_spec.rb
@@ -305,7 +305,6 @@ RSpec.describe Bundler::Settings::TCPSocketProbe do
end
it "probes the server correctly" do
- skip "obscure error" if Gem.win_platform?
with_server_and_mirror do |server, mirror|
expect(server.closed?).to be_falsey
diff --git a/spec/commands/binstubs_spec.rb b/spec/commands/binstubs_spec.rb
index a5e48753fb..57a97f6f74 100644
--- a/spec/commands/binstubs_spec.rb
+++ b/spec/commands/binstubs_spec.rb
@@ -2,7 +2,6 @@
RSpec.describe "bundle binstubs <gem>" do
before do
- skip "https://github.com/rubygems/bundler/issues/6894" if Gem.win_platform?
end
context "when the gem exists in the lockfile" do
@@ -278,7 +277,6 @@ RSpec.describe "bundle binstubs <gem>" do
end
it "sets correct permissions for binstubs" do
- skip "https://github.com/rubygems/bundler/issues/6895" if Gem.win_platform?
with_umask(0o002) do
install_gemfile <<-G
diff --git a/spec/commands/cache_spec.rb b/spec/commands/cache_spec.rb
index 04dfee5b16..64c143cc88 100644
--- a/spec/commands/cache_spec.rb
+++ b/spec/commands/cache_spec.rb
@@ -199,7 +199,6 @@ RSpec.describe "bundle cache" do
context "with --all-platforms" do
before do
- skip "doesn't put gems where it should" if Gem.win_platform?
end
it "puts the gems in vendor/cache even for other rubies" do
diff --git a/spec/commands/exec_spec.rb b/spec/commands/exec_spec.rb
index 17fc959baf..8b72d27a3c 100644
--- a/spec/commands/exec_spec.rb
+++ b/spec/commands/exec_spec.rb
@@ -68,7 +68,6 @@ RSpec.describe "bundle exec" do
end
it "respects custom process title when loading through ruby" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
script_that_changes_its_own_title_and_checks_if_picked_up_by_ps_unix_utility = <<~'RUBY'
Process.setproctitle("1-2-3-4-5-6-7-8-9-10-11-12-13-14-15")
@@ -93,7 +92,6 @@ RSpec.describe "bundle exec" do
end
it "handles --keep-file-descriptors" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
require "tempfile"
@@ -126,7 +124,6 @@ RSpec.describe "bundle exec" do
end
it "can run a command named --verbose" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
install_gemfile 'gem "rack"'
File.open(bundled_app("--verbose"), "w") do |f|
@@ -286,7 +283,6 @@ RSpec.describe "bundle exec" do
end
it "does not duplicate already exec'ed RUBYOPT" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
install_gemfile <<-G
gem "rack"
@@ -303,7 +299,6 @@ RSpec.describe "bundle exec" do
end
it "does not duplicate already exec'ed RUBYLIB" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
install_gemfile <<-G
gem "rack"
@@ -372,7 +367,6 @@ RSpec.describe "bundle exec" do
each_prefix.call("exec") do |exec|
describe "when #{exec} is used" do
before(:each) do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
install_gemfile <<-G
gem "rack"
@@ -587,7 +581,6 @@ RSpec.describe "bundle exec" do
describe "with gems bundled for deployment" do
it "works when calling bundler from another script" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
gemfile <<-G
module Monkey
@@ -642,7 +635,6 @@ RSpec.describe "bundle exec" do
shared_examples_for "it runs" do
it "like a normally executed executable" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
subject
expect(exitstatus).to eq(exit_code) if exitstatus
@@ -823,7 +815,6 @@ __FILE__: #{path.to_s.inspect}
RUBY
it "receives the signal" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
bundle!("exec #{path}") do |_, o, thr|
o.gets # Consumes 'Started' and ensures that thread has started
@@ -846,7 +837,6 @@ __FILE__: #{path.to_s.inspect}
RUBY
it "makes sure no unexpected signals are restored to DEFAULT" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
test_signals.each do |n|
Signal.trap(n, "IGNORE")
@@ -872,7 +862,6 @@ __FILE__: #{path.to_s.inspect}
end
it "correctly shells out", :ruby_repo do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
file = bundled_app("file_that_bundle_execs.rb")
create_file(file, <<-RB)
@@ -890,7 +879,6 @@ __FILE__: #{path.to_s.inspect}
let(:expected) { ruby "gem 'openssl', '< 999999'; require 'openssl'; puts OpenSSL::VERSION", :artifice => nil }
it "only leaves the default gem in the stdlib available" do
- skip "https://github.com/rubygems/bundler/issues/6898" if Gem.win_platform?
skip "openssl isn't a default gem" if expected.empty?
install_gemfile! "" # must happen before installing the broken system gem
diff --git a/spec/commands/help_spec.rb b/spec/commands/help_spec.rb
index 658b1374d4..d6eebb1763 100644
--- a/spec/commands/help_spec.rb
+++ b/spec/commands/help_spec.rb
@@ -28,7 +28,6 @@ RSpec.describe "bundle help" do
end
it "looks for a binary and executes it with --help option if it's named bundler-<task>" do
- skip "obscure error" if Gem.win_platform?
File.open(tmp("bundler-testtasks"), "w", 0o755) do |f|
f.puts "#!/usr/bin/env ruby\nputs ARGV.join(' ')\n"
diff --git a/spec/commands/install_spec.rb b/spec/commands/install_spec.rb
index 9a4ce33a26..cb888e88d0 100644
--- a/spec/commands/install_spec.rb
+++ b/spec/commands/install_spec.rb
@@ -218,7 +218,6 @@ RSpec.describe "bundle install with gem sources" do
describe "with a gem that installs multiple platforms" do
it "installs gems for the local platform as first choice" do
- skip "version is 1.0, not 1.0.0" if Gem.win_platform?
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
@@ -374,7 +373,6 @@ RSpec.describe "bundle install with gem sources" do
end
it "gracefully handles error when rubygems server is unavailable" do
- skip "networking issue" if Gem.win_platform?
install_gemfile <<-G, :artifice => nil
source "#{file_uri_for(gem_repo1)}"
diff --git a/spec/install/allow_offline_install_spec.rb b/spec/install/allow_offline_install_spec.rb
index 2662c12953..7103f17e50 100644
--- a/spec/install/allow_offline_install_spec.rb
+++ b/spec/install/allow_offline_install_spec.rb
@@ -7,7 +7,6 @@ RSpec.describe "bundle install with :allow_offline_install" do
context "with no cached data locally" do
it "still installs" do
- skip "corrupt test gem" if Gem.win_platform?
install_gemfile! <<-G, :artifice => "compact_index"
source "http://testgemserver.local"
@@ -28,7 +27,6 @@ RSpec.describe "bundle install with :allow_offline_install" do
context "with cached data locally" do
it "will install from the compact index" do
- skip "corrupt test gem" if Gem.win_platform?
system_gems ["rack-1.0.0"], :path => :bundle_path
@@ -74,7 +72,6 @@ RSpec.describe "bundle install with :allow_offline_install" do
end
it "will install from a cached git repo" do
- skip "doesn't print errors" if Gem.win_platform?
git = build_git "a", "1.0.0", :path => lib_path("a")
update_git("a", :path => git.path, :branch => "new_branch")
diff --git a/spec/install/deploy_spec.rb b/spec/install/deploy_spec.rb
index 5031bd9aa0..103ec69edd 100644
--- a/spec/install/deploy_spec.rb
+++ b/spec/install/deploy_spec.rb
@@ -64,7 +64,6 @@ RSpec.describe "install with --deployment or --frozen" do
end
it "works when you bundle exec bundle" do
- skip "doesn't find bundle" if Gem.win_platform?
bundle! :install
bundle "install --deployment"
@@ -84,7 +83,6 @@ RSpec.describe "install with --deployment or --frozen" do
end
it "works when there are credentials in the source URL" do
- skip "corrupt test gem" if Gem.win_platform?
install_gemfile(<<-G, :artifice => "endpoint_strict_basic_authentication", :quiet => true)
source "http://user:pass@localgemserver.test/"
diff --git a/spec/install/gemfile/gemspec_spec.rb b/spec/install/gemfile/gemspec_spec.rb
index b28d70a798..80b95419a1 100644
--- a/spec/install/gemfile/gemspec_spec.rb
+++ b/spec/install/gemfile/gemspec_spec.rb
@@ -331,7 +331,6 @@ RSpec.describe "bundle install from an existing gemspec" do
let(:platform) { "ruby" }
before do
- skip "not installing for some reason" if Gem.win_platform?
build_lib("foo", :path => tmp.join("foo")) do |s|
s.add_dependency "rack", "=1.0.0"
diff --git a/spec/install/gemfile/git_spec.rb b/spec/install/gemfile/git_spec.rb
index 067de1777d..b1f6109116 100644
--- a/spec/install/gemfile/git_spec.rb
+++ b/spec/install/gemfile/git_spec.rb
@@ -311,7 +311,6 @@ RSpec.describe "bundle install with git sources" do
context "when the branch starts with a `#`" do
let(:branch) { "#149/redirect-url-fragment" }
it "works" do
- skip "git does not accept this" if Gem.win_platform?
update_git("foo", :path => repo, :branch => branch)
@@ -328,7 +327,6 @@ RSpec.describe "bundle install with git sources" do
context "when the branch includes quotes" do
let(:branch) { %('") }
it "works" do
- skip "git does not accept this" if Gem.win_platform?
update_git("foo", :path => repo, :branch => branch)
@@ -362,7 +360,6 @@ RSpec.describe "bundle install with git sources" do
context "when the tag starts with a `#`" do
let(:tag) { "#149/redirect-url-fragment" }
it "works" do
- skip "git does not accept this" if Gem.win_platform?
update_git("foo", :path => repo, :tag => tag)
@@ -379,7 +376,6 @@ RSpec.describe "bundle install with git sources" do
context "when the tag includes quotes" do
let(:tag) { %('") }
it "works" do
- skip "git does not accept this" if Gem.win_platform?
update_git("foo", :path => repo, :tag => tag)
@@ -623,7 +619,6 @@ RSpec.describe "bundle install with git sources" do
end
it "installs dependencies from git even if a newer gem is available elsewhere" do
- skip "override is not winning" if Gem.win_platform?
system_gems "rack-1.0.0"
@@ -914,7 +909,6 @@ RSpec.describe "bundle install with git sources" do
end
it "prints a friendly error if a file blocks the git repo" do
- skip "drive letter is not detected correctly in error message" if Gem.win_platform?
build_git "foo"
diff --git a/spec/install/gemfile/path_spec.rb b/spec/install/gemfile/path_spec.rb
index a733c02512..e8e12a793e 100644
--- a/spec/install/gemfile/path_spec.rb
+++ b/spec/install/gemfile/path_spec.rb
@@ -59,7 +59,6 @@ RSpec.describe "bundle install with explicit source paths" do
end
it "expands paths raise error with not existing user's home dir" do
- skip "problems with ~ expansion" if Gem.win_platform?
build_lib "foo"
username = "some_unexisting_user"
@@ -136,7 +135,6 @@ RSpec.describe "bundle install with explicit source paths" do
end
it "installs dependencies from the path even if a newer gem is available elsewhere" do
- skip "override is not winning" if Gem.win_platform?
system_gems "rack-1.0.0"
@@ -637,7 +635,6 @@ RSpec.describe "bundle install with explicit source paths" do
describe "when there are both a gemspec and remote gems" do
it "doesn't query rubygems for local gemspec name" do
- skip "platform issues" if Gem.win_platform?
build_lib "private_lib", "2.2", :path => lib_path("private_lib")
gemfile = <<-G
diff --git a/spec/install/gemfile/platform_spec.rb b/spec/install/gemfile/platform_spec.rb
index 52e1cf86fa..396c6a6b29 100644
--- a/spec/install/gemfile/platform_spec.rb
+++ b/spec/install/gemfile/platform_spec.rb
@@ -274,7 +274,6 @@ end
RSpec.describe "bundle install with platform conditionals" do
it "installs gems tagged w/ the current platforms" do
- skip "platform issues" if Gem.win_platform?
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
@@ -301,7 +300,6 @@ RSpec.describe "bundle install with platform conditionals" do
end
it "installs gems tagged w/ the current platforms inline" do
- skip "platform issues" if Gem.win_platform?
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
@@ -321,7 +319,6 @@ RSpec.describe "bundle install with platform conditionals" do
end
it "installs gems tagged w/ the current platform inline" do
- skip "platform issues" if Gem.win_platform?
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
diff --git a/spec/install/gems/compact_index_spec.rb b/spec/install/gems/compact_index_spec.rb
index be6c01aee9..6b61394788 100644
--- a/spec/install/gems/compact_index_spec.rb
+++ b/spec/install/gems/compact_index_spec.rb
@@ -5,7 +5,6 @@ RSpec.describe "compact index api" do
let(:source_uri) { "http://#{source_hostname}" }
it "should use the API" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -28,7 +27,6 @@ RSpec.describe "compact index api" do
end
it "should handle nested dependencies" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -48,7 +46,6 @@ RSpec.describe "compact index api" do
end
it "should handle case sensitivity conflicts" do
- skip "artifice issues?" if Gem.win_platform?
build_repo4 do
build_gem "rack", "1.0" do |s|
@@ -70,7 +67,6 @@ RSpec.describe "compact index api" do
end
it "should handle multiple gem dependencies on the same gem" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -82,7 +78,6 @@ RSpec.describe "compact index api" do
end
it "should use the endpoint when using --deployment" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -96,7 +91,6 @@ RSpec.describe "compact index api" do
end
it "handles git dependencies that are in rubygems" do
- skip "artifice issues?" if Gem.win_platform?
build_git "foo" do |s|
s.executables = "foobar"
@@ -116,7 +110,6 @@ RSpec.describe "compact index api" do
end
it "handles git dependencies that are in rubygems using --deployment" do
- skip "artifice issues?" if Gem.win_platform?
build_git "foo" do |s|
s.executables = "foobar"
@@ -162,7 +155,6 @@ RSpec.describe "compact index api" do
end
it "falls back when the API URL returns 403 Forbidden" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -175,7 +167,6 @@ RSpec.describe "compact index api" do
end
it "falls back when the versions endpoint has a checksum mismatch" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -191,7 +182,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "falls back when the user's home directory does not exist or is not writable" do
- skip "artifice issues?" if Gem.win_platform?
ENV["HOME"] = tmp("missing_home").to_s
@@ -206,7 +196,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "handles host redirects" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -218,7 +207,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "handles host redirects without Net::HTTP::Persistent" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -244,7 +232,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "times out when Bundler::Fetcher redirects too much" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -257,7 +244,6 @@ The checksum of /versions does not match the checksum provided by the server! So
context "when --full-index is specified" do
before do
- skip "artifice issues?" if Gem.win_platform?
end
it "should use the modern index for install" do
@@ -300,7 +286,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "fetches again when more dependencies are found in subsequent sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -320,7 +305,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "fetches again when more dependencies are found in subsequent sources with source blocks" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -340,7 +324,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "fetches gem versions even when those gems are already installed" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -365,7 +348,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "considers all possible versions of dependencies from all api gem sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
# In this scenario, the gem "somegem" only exists in repo4. It depends on specific version of activesupport that
# exists only in repo1. There happens also be a version of activesupport in repo4, but not the one that version 1.0.0
@@ -391,7 +373,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "considers all possible versions of dependencies from all api gem sources when using blocks", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
# In this scenario, the gem "somegem" only exists in repo4. It depends on specific version of activesupport that
# exists only in repo1. There happens also be a version of activesupport in repo4, but not the one that version 1.0.0
@@ -418,7 +399,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "prints API output properly with back deps" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -441,7 +421,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "does not fetch every spec if the index of gems is large when doing back deps" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -468,7 +447,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "does not fetch every spec if the index of gems is large when doing back deps & everything is the compact index" do
- skip "artifice issues?" if Gem.win_platform?
build_repo4 do
build_gem "back_deps" do |s|
@@ -494,7 +472,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "uses the endpoint if all sources support it" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -507,7 +484,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "fetches again when more dependencies are found in subsequent sources using --deployment", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -529,7 +505,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "fetches again when more dependencies are found in subsequent sources using --deployment with blocks" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -552,7 +527,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "does not refetch if the only unmet dependency is bundler" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -577,7 +551,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "installs the binstubs", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -591,7 +564,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "installs the bins when using --path and uses autoclean", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -604,7 +576,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "installs the bins when using --path and uses bundle clean", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -617,7 +588,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "prints post_install_messages" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -629,7 +599,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "should display the post install message for a dependency" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -653,7 +622,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "passes basic authentication details and strips out creds" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -666,7 +634,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "strips http basic authentication creds for modern index" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -689,7 +656,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "strips http basic auth creds when warning about ambiguous sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -704,7 +670,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "does not pass the user / password to different hosts on redirect" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -724,7 +689,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "reads authentication details by host name from bundle config" do
- skip "artifice issues?" if Gem.win_platform?
bundle "config set #{source_hostname} #{user}:#{password}"
@@ -735,7 +699,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "reads authentication details by full url from bundle config" do
- skip "artifice issues?" if Gem.win_platform?
# The trailing slash is necessary here; Fetcher canonicalizes the URI.
bundle "config set #{source_uri}/ #{user}:#{password}"
@@ -747,7 +710,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "should use the API" do
- skip "artifice issues?" if Gem.win_platform?
bundle "config set #{source_hostname} #{user}:#{password}"
bundle! :install, :artifice => "compact_index_strict_basic_authentication"
@@ -756,7 +718,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "prefers auth supplied in the source uri" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -786,7 +747,6 @@ The checksum of /versions does not match the checksum provided by the server! So
let(:password) { nil }
it "passes basic authentication details" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -845,7 +805,6 @@ The checksum of /versions does not match the checksum provided by the server! So
context ".gemrc with sources is present" do
it "uses other sources declared in the Gemfile" do
- skip "artifice issues?" if Gem.win_platform?
File.open(home(".gemrc"), "w") do |file|
file.puts({ :sources => ["https://rubygems.org"] }.to_yaml)
@@ -867,7 +826,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "performs partial update with a non-empty range" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -890,7 +848,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "performs partial update while local cache is updated by another process" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -910,7 +867,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "performs full update of compact index info cache if range is not satisfiable" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -955,7 +911,6 @@ The checksum of /versions does not match the checksum provided by the server! So
describe "checksum validation" do
it "raises when the checksum does not match" do
- skip "artifice issues?" if Gem.win_platform?
install_gemfile <<-G, :artifice => "compact_index_wrong_gem_checksum"
source "#{source_uri}"
@@ -977,7 +932,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "raises when the checksum is the wrong length" do
- skip "artifice issues?" if Gem.win_platform?
install_gemfile <<-G, :artifice => "compact_index_wrong_gem_checksum", :env => { "BUNDLER_SPEC_RACK_CHECKSUM" => "checksum!" }
source "#{source_uri}"
@@ -988,7 +942,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "does not raise when disable_checksum_validation is set" do
- skip "artifice issues?" if Gem.win_platform?
bundle! "config set disable_checksum_validation true"
install_gemfile! <<-G, :artifice => "compact_index_wrong_gem_checksum"
@@ -999,7 +952,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "works when cache dir is world-writable" do
- skip "artifice issues?" if Gem.win_platform?
install_gemfile! <<-G, :artifice => "compact_index"
File.umask(0000)
@@ -1009,7 +961,6 @@ The checksum of /versions does not match the checksum provided by the server! So
end
it "doesn't explode when the API dependencies are wrong" do
- skip "artifice issues?" if Gem.win_platform?
install_gemfile <<-G, :artifice => "compact_index_wrong_dependencies", :env => { "DEBUG" => "true" }
source "#{source_uri}"
@@ -1027,7 +978,6 @@ Either installing with `--full-index` or running `bundle update rails` should fi
end
it "does not duplicate specs in the lockfile when updating and a dependency is not installed" do
- skip "artifice issues?" if Gem.win_platform?
install_gemfile! <<-G, :artifice => "compact_index"
source "#{source_uri}" do
diff --git a/spec/install/gems/dependency_api_spec.rb b/spec/install/gems/dependency_api_spec.rb
index 78cca5f8b7..9bdfd5a4ea 100644
--- a/spec/install/gems/dependency_api_spec.rb
+++ b/spec/install/gems/dependency_api_spec.rb
@@ -5,7 +5,6 @@ RSpec.describe "gemcutter's dependency API" do
let(:source_uri) { "http://#{source_hostname}" }
it "should use the API" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -28,7 +27,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "should handle nested dependencies" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -48,7 +46,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "should handle multiple gem dependencies on the same gem" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -60,7 +57,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "should use the endpoint when using --deployment" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -74,7 +70,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "handles git dependencies that are in rubygems" do
- skip "artifice issues?" if Gem.win_platform?
build_git "foo" do |s|
s.executables = "foobar"
@@ -94,7 +89,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "handles git dependencies that are in rubygems using --deployment" do
- skip "artifice issues?" if Gem.win_platform?
build_git "foo" do |s|
s.executables = "foobar"
@@ -140,7 +134,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "falls back when hitting the Gemcutter Dependency Limit" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -168,7 +161,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "falls back when Gemcutter API doesn't return proper Marshal format" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -181,7 +173,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "falls back when the API URL returns 403 Forbidden" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -194,7 +185,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "handles host redirects" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -206,7 +196,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "handles host redirects without Net::HTTP::Persistent" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -232,7 +221,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "timeouts when Bundler::Fetcher redirects too much" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -245,7 +233,6 @@ RSpec.describe "gemcutter's dependency API" do
context "when --full-index is specified" do
before do
- skip "artifice issues?" if Gem.win_platform?
end
it "should use the modern index for install" do
@@ -272,7 +259,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "fetches again when more dependencies are found in subsequent sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -292,7 +278,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "fetches again when more dependencies are found in subsequent sources using blocks" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -313,7 +298,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "fetches gem versions even when those gems are already installed" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -337,7 +321,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "considers all possible versions of dependencies from all api gem sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
# In this scenario, the gem "somegem" only exists in repo4. It depends on specific version of activesupport that
# exists only in repo1. There happens also be a version of activesupport in repo4, but not the one that version 1.0.0
@@ -363,7 +346,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "considers all possible versions of dependencies from all api gem sources using blocks" do
- skip "artifice issues?" if Gem.win_platform?
# In this scenario, the gem "somegem" only exists in repo4. It depends on specific version of activesupport that
# exists only in repo1. There happens also be a version of activesupport in repo4, but not the one that version 1.0.0
@@ -390,7 +372,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "prints API output properly with back deps" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -413,7 +394,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "does not fetch every spec if the index of gems is large when doing back deps", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -439,7 +419,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "does not fetch every spec if the index of gems is large when doing back deps using blocks" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -466,7 +445,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "uses the endpoint if all sources support it" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -479,7 +457,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "fetches again when more dependencies are found in subsequent sources using --deployment", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -501,7 +478,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "fetches again when more dependencies are found in subsequent sources using --deployment with blocks" do
- skip "artifice issues?" if Gem.win_platform?
build_repo2 do
build_gem "back_deps" do |s|
@@ -547,7 +523,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "installs the binstubs", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -561,7 +536,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "installs the bins when using --path and uses autoclean", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -574,7 +548,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "installs the bins when using --path and uses bundle clean", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -587,7 +560,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "prints post_install_messages" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -599,7 +571,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "should display the post install message for a dependency" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -623,7 +594,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "passes basic authentication details and strips out creds" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -636,7 +606,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "strips http basic authentication creds for modern index" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -659,7 +628,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "strips http basic auth creds when warning about ambiguous sources", :bundler => "< 3" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -674,7 +642,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "does not pass the user / password to different hosts on redirect" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -694,7 +661,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "reads authentication details by host name from bundle config" do
- skip "artifice issues?" if Gem.win_platform?
bundle "config set #{source_hostname} #{user}:#{password}"
@@ -705,7 +671,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "reads authentication details by full url from bundle config" do
- skip "artifice issues?" if Gem.win_platform?
# The trailing slash is necessary here; Fetcher canonicalizes the URI.
bundle "config set #{source_uri}/ #{user}:#{password}"
@@ -717,7 +682,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "should use the API" do
- skip "artifice issues?" if Gem.win_platform?
bundle "config set #{source_hostname} #{user}:#{password}"
bundle :install, :artifice => "endpoint_strict_basic_authentication"
@@ -726,7 +690,6 @@ RSpec.describe "gemcutter's dependency API" do
end
it "prefers auth supplied in the source uri" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -756,7 +719,6 @@ RSpec.describe "gemcutter's dependency API" do
let(:password) { nil }
it "passes basic authentication details" do
- skip "artifice issues?" if Gem.win_platform?
gemfile <<-G
source "#{basic_auth_source_uri}"
@@ -815,7 +777,6 @@ RSpec.describe "gemcutter's dependency API" do
context ".gemrc with sources is present" do
it "uses other sources declared in the Gemfile" do
- skip "artifice issues?" if Gem.win_platform?
File.open(home(".gemrc"), "w") do |file|
file.puts({ :sources => ["https://rubygems.org"] }.to_yaml)
diff --git a/spec/install/gems/resolving_spec.rb b/spec/install/gems/resolving_spec.rb
index 323b28fdb1..131778e260 100644
--- a/spec/install/gems/resolving_spec.rb
+++ b/spec/install/gems/resolving_spec.rb
@@ -19,7 +19,6 @@ RSpec.describe "bundle install with install-time dependencies" do
end
it "installs gems with a dependency with no type" do
- skip "incorrect data check error" if Gem.win_platform?
build_repo2
@@ -118,7 +117,6 @@ RSpec.describe "bundle install with install-time dependencies" do
describe "when a required ruby version" do
context "allows only an older version" do
before do
- skip "gem not found" if Gem.win_platform?
end
it "installs the older version" do
@@ -205,7 +203,6 @@ RSpec.describe "bundle install with install-time dependencies" do
shared_examples_for "ruby version conflicts" do
it "raises an error during resolution" do
- skip "ruby requirement includes platform and it shouldn't" if Gem.win_platform?
install_gemfile <<-G, :artifice => "compact_index", :env => { "BUNDLER_SPEC_GEM_REPO" => gem_repo2.to_s }
source "http://localgemserver.test/"
diff --git a/spec/install/gems/standalone_spec.rb b/spec/install/gems/standalone_spec.rb
index c7c9d2a6a9..1e6ce9f082 100644
--- a/spec/install/gems/standalone_spec.rb
+++ b/spec/install/gems/standalone_spec.rb
@@ -226,7 +226,6 @@ RSpec.shared_examples "bundle install --standalone" do
describe "simple gems" do
before do
- skip "artifice issues maybe" if Gem.win_platform?
gemfile <<-G
source "#{source_uri}"
@@ -265,13 +264,11 @@ RSpec.shared_examples "bundle install --standalone" do
include_examples "common functionality"
it "creates stubs that use the standalone load path" do
- skip "exec format error" if Gem.win_platform?
expect(sys_exec("bin/rails -v").chomp).to eql "2.3.2"
end
it "creates stubs that can be executed from anywhere" do
- skip "exec format error" if Gem.win_platform?
require "tmpdir"
sys_exec!(%(#{bundled_app("bin/rails")} -v), :dir => Dir.tmpdir)
@@ -279,7 +276,6 @@ RSpec.shared_examples "bundle install --standalone" do
end
it "creates stubs that can be symlinked" do
- skip "symlinks unsupported" if Gem.win_platform?
symlink_dir = tmp("symlink")
FileUtils.mkdir_p(symlink_dir)
diff --git a/spec/install/gemspecs_spec.rb b/spec/install/gemspecs_spec.rb
index 048987af9b..37bcdefb74 100644
--- a/spec/install/gemspecs_spec.rb
+++ b/spec/install/gemspecs_spec.rb
@@ -28,7 +28,6 @@ RSpec.describe "bundle install" do
end
it "should use gemspecs in the system cache when available" do
- skip "weird incompatible marshal file format error" if Gem.win_platform?
gemfile <<-G
source "http://localtestserver.gem"
diff --git a/spec/install/git_spec.rb b/spec/install/git_spec.rb
index 1b32991fa8..7cc004ae7c 100644
--- a/spec/install/git_spec.rb
+++ b/spec/install/git_spec.rb
@@ -14,7 +14,6 @@ RSpec.describe "bundle install" do
end
it "displays the ref of the gem repository when using branch~num as a ref", :bundler => "< 3" do
- skip "maybe branch~num notation doesn't work on Windows' git" if Gem.win_platform?
build_git "foo", "1.0", :path => lib_path("foo")
rev = revision_for(lib_path("foo"))[0..6]
diff --git a/spec/install/global_cache_spec.rb b/spec/install/global_cache_spec.rb
index 15987bdf53..a57e76eb94 100644
--- a/spec/install/global_cache_spec.rb
+++ b/spec/install/global_cache_spec.rb
@@ -16,7 +16,6 @@ RSpec.describe "global gem caching" do
end
it "caches gems into the global cache on download" do
- skip "corrupt test gem" if Gem.win_platform?
install_gemfile! <<-G, :artifice => "compact_index"
source "#{source}"
@@ -41,7 +40,6 @@ RSpec.describe "global gem caching" do
describe "when the same gem from different sources is installed" do
before do
- skip "corrupt test gem" if Gem.win_platform?
end
it "should use the appropriate one from the global cache" do
@@ -140,7 +138,6 @@ RSpec.describe "global gem caching" do
describe "when installing gems from a different directory" do
it "uses the global cache as a source" do
- skip "corrupt test gem" if Gem.win_platform?
install_gemfile! <<-G, :artifice => "compact_index"
source "#{source}"
@@ -195,7 +192,6 @@ RSpec.describe "global gem caching" do
describe "extension caching", :ruby_repo do
it "works" do
- skip "gets incorrect ref in path" if Gem.win_platform?
build_git "very_simple_git_binary", &:add_c_extension
build_lib "very_simple_path_binary", &:add_c_extension
diff --git a/spec/lock/lockfile_spec.rb b/spec/lock/lockfile_spec.rb
index afcb89ba8a..b38f1f879e 100644
--- a/spec/lock/lockfile_spec.rb
+++ b/spec/lock/lockfile_spec.rb
@@ -303,7 +303,6 @@ RSpec.describe "the lockfile format" do
end
it "generates a lockfile without credentials for a configured source", :bundler => "< 3" do
- skip "corrupt test gem" if Gem.win_platform?
bundle "config set http://localgemserver.test/ user:pass"
@@ -1405,7 +1404,6 @@ RSpec.describe "the lockfile format" do
end
it "preserves Gemfile.lock \\n\\r line endings" do
- skip "needs to be adapted" if Gem.win_platform?
update_repo2
win_lock = File.read(bundled_app_lock).gsub(/\n/, "\r\n")
diff --git a/spec/runtime/executable_spec.rb b/spec/runtime/executable_spec.rb
index e420594f52..dddd9cf600 100644
--- a/spec/runtime/executable_spec.rb
+++ b/spec/runtime/executable_spec.rb
@@ -9,7 +9,6 @@ RSpec.describe "Running bin/* commands" do
end
it "runs the bundled command when in the bundle" do
- skip "exec format error" if Gem.win_platform?
bundle! "binstubs rack"
@@ -22,7 +21,6 @@ RSpec.describe "Running bin/* commands" do
end
it "allows the location of the gem stubs to be specified" do
- skip "created in bin :/" if Gem.win_platform?
bundle! "binstubs rack", :path => "gbin"
@@ -34,7 +32,6 @@ RSpec.describe "Running bin/* commands" do
end
it "allows absolute paths as a specification of where to install bin stubs" do
- skip "exec format error" if Gem.win_platform?
bundle! "binstubs rack", :path => tmp("bin")
@@ -48,14 +45,12 @@ RSpec.describe "Running bin/* commands" do
end
it "allows the name of the shebang executable to be specified" do
- skip "not created with custom name :/" if Gem.win_platform?
bundle! "binstubs rack", :shebang => "ruby-foo"
expect(File.open(bundled_app("bin/rackup")).gets).to eq("#!/usr/bin/env ruby-foo\n")
end
it "runs the bundled command when out of the bundle" do
- skip "exec format error" if Gem.win_platform?
bundle! "binstubs rack"
@@ -68,7 +63,6 @@ RSpec.describe "Running bin/* commands" do
end
it "works with gems in path" do
- skip "exec format error" if Gem.win_platform?
build_lib "rack", :path => lib_path("rack") do |s|
s.executables = "rackup"
@@ -104,7 +98,6 @@ RSpec.describe "Running bin/* commands" do
end
it "does not generate bin stubs if the option was not specified" do
- skip "generated :/" if Gem.win_platform?
bundle! "install"
@@ -112,7 +105,6 @@ RSpec.describe "Running bin/* commands" do
end
it "allows you to stop installing binstubs", :bundler => "< 3" do
- skip "delete permission error" if Gem.win_platform?
bundle! "install --binstubs bin/"
bundled_app("bin/rackup").rmtree
@@ -157,7 +149,6 @@ RSpec.describe "Running bin/* commands" do
end
it "use BUNDLE_GEMFILE gemfile for binstub" do
- skip "exec format error" if Gem.win_platform?
# context with bin/bundler w/ default Gemfile
bundle! "binstubs bundler"
diff --git a/spec/runtime/inline_spec.rb b/spec/runtime/inline_spec.rb
index fb6c6e90ad..2a4d171f14 100644
--- a/spec/runtime/inline_spec.rb
+++ b/spec/runtime/inline_spec.rb
@@ -46,7 +46,6 @@ RSpec.describe "bundler/inline#gemfile" do
end
it "requires the gems" do
- skip "gems not found" if Gem.win_platform?
script <<-RUBY
gemfile do
@@ -97,7 +96,6 @@ RSpec.describe "bundler/inline#gemfile" do
end
it "lets me use my own ui object" do
- skip "prints just one CONFIRMED" if Gem.win_platform?
script <<-RUBY, :artifice => "endpoint"
require '#{lib_dir}/bundler'
diff --git a/spec/runtime/require_spec.rb b/spec/runtime/require_spec.rb
index a2e6ba7244..d7fb0beb23 100644
--- a/spec/runtime/require_spec.rb
+++ b/spec/runtime/require_spec.rb
@@ -434,7 +434,6 @@ RSpec.describe "Bundler.require with platform specific dependencies" do
end
it "requires gems pinned to multiple platforms, including the current one" do
- skip "platform issues" if Gem.win_platform?
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
diff --git a/spec/runtime/setup_spec.rb b/spec/runtime/setup_spec.rb
index f94efbea6a..0f8c614d2a 100644
--- a/spec/runtime/setup_spec.rb
+++ b/spec/runtime/setup_spec.rb
@@ -794,7 +794,6 @@ end
let(:full_name) { "bundler-#{Bundler::VERSION}" }
before do
- skip "symlink destination exists" if Gem.win_platform?
FileUtils.ln_sf(gem_home, symlinked_gem_home)
gems_dir = File.join(gem_home, "gems")
@@ -1014,7 +1013,6 @@ end
end
it "error intelligently if the gemspec has a LoadError" do
- skip "whitespace issue?" if Gem.win_platform?
ref = update_git "bar", :gemspec => false do |s|
s.write "bar.gemspec", "require 'foobarbaz'"
@@ -1259,7 +1257,6 @@ end
end
it "activates no gems with bundle exec that is loaded" do
- skip "not executable" if Gem.win_platform?
install_gemfile! ""
create_file("script.rb", "#!/usr/bin/env ruby\n\n#{code}")
diff --git a/spec/runtime/with_unbundled_env_spec.rb b/spec/runtime/with_unbundled_env_spec.rb
index 81fdf0aaea..2fa572f74c 100644
--- a/spec/runtime/with_unbundled_env_spec.rb
+++ b/spec/runtime/with_unbundled_env_spec.rb
@@ -170,7 +170,6 @@ RSpec.describe "Bundler.with_env helpers" do
end
it "runs system inside with_original_env" do
- skip "obscure error" if Gem.win_platform?
system({ "BUNDLE_FOO" => "bar" }, "ruby -I#{lib_dir} -rbundler -e '#{code}'")
expect($?.exitstatus).to eq(42)
@@ -187,7 +186,6 @@ RSpec.describe "Bundler.with_env helpers" do
end
it "runs system inside with_clean_env" do
- skip "obscure error" if Gem.win_platform?
system({ "BUNDLE_FOO" => "bar" }, "ruby -I#{lib_dir} -rbundler -e '#{code}'")
expect($?.exitstatus).to eq(42)
@@ -223,7 +221,6 @@ RSpec.describe "Bundler.with_env helpers" do
end
it "runs exec inside with_original_env" do
- skip "Fork not implemented" if Gem.win_platform?
system({ "BUNDLE_FOO" => "bar" }, "ruby -I#{lib_dir} -rbundler -e '#{code}'")
expect($?.exitstatus).to eq(0)
@@ -244,7 +241,6 @@ RSpec.describe "Bundler.with_env helpers" do
end
it "runs exec inside with_clean_env" do
- skip "Fork not implemented" if Gem.win_platform?
system({ "BUNDLE_FOO" => "bar" }, "ruby -I#{lib_dir} -rbundler -e '#{code}'")
expect($?.exitstatus).to eq(1)
@@ -265,7 +261,6 @@ RSpec.describe "Bundler.with_env helpers" do
end
it "runs exec inside with_clean_env" do
- skip "Fork not implemented" if Gem.win_platform?
system({ "BUNDLE_FOO" => "bar" }, "ruby -I#{lib_dir} -rbundler -e '#{code}'")
expect($?.exitstatus).to eq(1)
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb
index dde8daaf6f..3c82888a11 100644
--- a/spec/support/helpers.rb
+++ b/spec/support/helpers.rb
@@ -347,8 +347,6 @@ module Spec
end
def with_fake_man
- skip "fake_man is not a Windows friendly binstub" if Gem.win_platform?
-
FileUtils.mkdir_p(tmp("fake_man"))
File.open(tmp("fake_man/man"), "w", 0o755) do |f|
f.puts "#!/usr/bin/env ruby\nputs ARGV.inspect\n"