summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-03-21 12:46:12 +0100
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-04-05 13:19:05 +0200
commit4ca104a6533e0c0599f34180c6ab35fa8c9015a3 (patch)
tree518ad7d48171f9f2b0fa6dcf1fbb3293f2fc707f
parent143f87e9104cfcfe4fb90c80c7171bdbdb2ec038 (diff)
downloadbundler-simplify_deprecation_specs.tar.gz
Remove one more nesting levelsimplify_deprecation_specs
For consistency with other specs.
-rw-r--r--spec/other/major_deprecation_spec.rb76
1 files changed, 38 insertions, 38 deletions
diff --git a/spec/other/major_deprecation_spec.rb b/spec/other/major_deprecation_spec.rb
index 9c5228b5c3..d041fd13bd 100644
--- a/spec/other/major_deprecation_spec.rb
+++ b/spec/other/major_deprecation_spec.rb
@@ -298,48 +298,48 @@ RSpec.describe "major deprecations" do
expect(the_bundle).not_to include_gem "rack 1.0"
end
+ end
- context "with flags" do
- before do
- install_gemfile <<-G, :path => "vendor/bundle"
- source "file://#{gem_repo1}"
- gem "rack"
- G
- end
-
- {
- :clean => true,
- :deployment => true,
- :frozen => true,
- :"no-cache" => true,
- :"no-prune" => true,
- :path => "vendor/bundle",
- :shebang => "ruby27",
- :system => true,
- :without => "development",
- :with => "development",
- }.each do |name, value|
- flag_name = "--#{name}"
-
- context "with the #{flag_name} flag", :bundler => "2" do
- it "should print a deprecation warning" do
- bundle "install #{flag_name} #{value}"
-
- expect(deprecations).to include(
- "The `#{flag_name}` flag is deprecated because it relies on " \
- "being remembered accross bundler invokations, which bundler " \
- "will no longer do in future versions. Instead please use " \
- "`bundle config #{name} '#{value}'`, and stop using this flag"
- )
- end
+ context "bundle install with flags" do
+ before do
+ install_gemfile <<-G, :path => "vendor/bundle"
+ source "file://#{gem_repo1}"
+ gem "rack"
+ G
+ end
+
+ {
+ :clean => true,
+ :deployment => true,
+ :frozen => true,
+ :"no-cache" => true,
+ :"no-prune" => true,
+ :path => "vendor/bundle",
+ :shebang => "ruby27",
+ :system => true,
+ :without => "development",
+ :with => "development",
+ }.each do |name, value|
+ flag_name = "--#{name}"
+
+ context "with the #{flag_name} flag", :bundler => "2" do
+ it "should print a deprecation warning" do
+ bundle "install #{flag_name} #{value}"
+
+ expect(deprecations).to include(
+ "The `#{flag_name}` flag is deprecated because it relies on " \
+ "being remembered accross bundler invokations, which bundler " \
+ "will no longer do in future versions. Instead please use " \
+ "`bundle config #{name} '#{value}'`, and stop using this flag"
+ )
end
+ end
- context "with the #{flag_name} flag", :bundler => "< 2" do
- it "should not print a deprecation warning" do
- bundle "install #{flag_name} #{value}"
+ context "with the #{flag_name} flag", :bundler => "< 2" do
+ it "should not print a deprecation warning" do
+ bundle "install #{flag_name} #{value}"
- expect(deprecations).to be_empty
- end
+ expect(deprecations).to be_empty
end
end
end