summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Giddins <segiddins@segiddins.me>2016-09-12 23:35:07 +0200
committerSamuel Giddins <segiddins@segiddins.me>2016-09-16 14:42:43 +0200
commit9628e2242faa80738e021c2474b5f9d888e130ff (patch)
treef26c007ba8fdd6f7994e3cb607a67fb54239329c
parent695db9a169294ec0c6fef3c14ef0f0ac1f6cc65c (diff)
downloadbundler-seg-pare-metadata-error.tar.gz
[EndpointSpecification] Raise a helpful error when parsing metadata failsseg-pare-metadata-error
-rw-r--r--lib/bundler/endpoint_specification.rb2
-rw-r--r--spec/bundler/endpoint_specification_spec.rb13
2 files changed, 15 insertions, 0 deletions
diff --git a/lib/bundler/endpoint_specification.rb b/lib/bundler/endpoint_specification.rb
index 69d05167e8..4f5377d3cc 100644
--- a/lib/bundler/endpoint_specification.rb
+++ b/lib/bundler/endpoint_specification.rb
@@ -113,6 +113,8 @@ module Bundler
@required_ruby_version = Gem::Requirement.new(v)
end
end
+ rescue => e
+ raise GemspecError, "There was an error parsing the metadata for the gem #{name} (#{version}): #{e.class}\n#{e}\nThe metadata was #{data.inspect}"
end
def build_dependency(name, requirements)
diff --git a/spec/bundler/endpoint_specification_spec.rb b/spec/bundler/endpoint_specification_spec.rb
index 6718b24971..b1e71df39a 100644
--- a/spec/bundler/endpoint_specification_spec.rb
+++ b/spec/bundler/endpoint_specification_spec.rb
@@ -50,4 +50,17 @@ describe Bundler::EndpointSpecification do
end
end
end
+
+ describe "#parse_metadata" do
+ context "when the metadata has malformed requirements" do
+ let(:metadata) { { "rubygems" => ">\n" } }
+ it "raises a helpful error message" do
+ expect { subject }.to raise_error(
+ Bundler::GemspecError,
+ a_string_including("There was an error parsing the metadata for the gem foo (1.0.0)").
+ and(a_string_including('The metadata was {"rubygems"=>">\n"}'))
+ )
+ end
+ end
+ end
end