diff options
| author | Samuel Giddins <segiddins@segiddins.me> | 2016-08-09 11:25:02 -0500 |
|---|---|---|
| committer | Samuel Giddins <segiddins@segiddins.me> | 2016-08-09 11:25:02 -0500 |
| commit | f1d68b30030758b739639740180aafa5300d97e3 (patch) | |
| tree | b7ba0f4d98ab5b304acc9f3a11ab13fb798a0a3d | |
| parent | 114d42b4591f18bffac0af1b87f5bc37a41d81e6 (diff) | |
| download | bundler-seg-ban-simply.tar.gz | |
Ban the usage of the word simplyseg-ban-simply
| -rw-r--r-- | man/bundle-package.ronn | 2 | ||||
| -rw-r--r-- | man/gemfile.5.ronn | 2 | ||||
| -rw-r--r-- | spec/quality_spec.rb | 13 |
3 files changed, 13 insertions, 4 deletions
diff --git a/man/bundle-package.ronn b/man/bundle-package.ronn index eacb83b54d..512b037f51 100644 --- a/man/bundle-package.ronn +++ b/man/bundle-package.ronn @@ -27,7 +27,7 @@ in your local bundler configuration. ## REMOTE FETCHING -By default, if you simply run [bundle install(1)][bundle-install] after running +By default, if you run [bundle install(1)][bundle-install] after running [bundle package(1)][bundle-package], bundler will still connect to `rubygems.org` to check whether a platform-specific gem exists for any of the gems in `vendor/cache`. diff --git a/man/gemfile.5.ronn b/man/gemfile.5.ronn index 61f76a8714..da2157e971 100644 --- a/man/gemfile.5.ronn +++ b/man/gemfile.5.ronn @@ -42,7 +42,7 @@ credentials from being stored in plain text in version control. bundle config gems.example.com user:password -For some sources, like a company Gemfury account, it may be easier to simply +For some sources, like a company Gemfury account, it may be easier to include the credentials in the Gemfile as part of the source URL. source "https://user:password@gems.example.com" diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb index 80ea22a9bb..5f73228b4a 100644 --- a/spec/quality_spec.rb +++ b/spec/quality_spec.rb @@ -77,10 +77,19 @@ describe "The library itself" do def check_for_expendable_words(filename) failing_line_message = [] - useless_words = /\b(actually|obviously|just|clearly|basically|really)\b/i + useless_words = %w( + actually + basically + clearly + just + obviously + really + simply + ) + pattern = /\b#{Regexp.union(useless_words)}\b/i File.readlines(filename).each_with_index do |line, number| - next unless word_found = useless_words.match(line) + next unless word_found = pattern.match(line) failing_line_message << "#{filename} has '#{word_found}' on line #{number + 1}. Avoid using these kinds of weak modifiers." end |