summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHiroshi SHIBATA <hsbt@ruby-lang.org>2019-12-14 21:19:28 +0900
committerDavid Rodríguez <deivid.rodriguez@riseup.net>2019-12-14 15:34:48 +0100
commitf8058353c2e0aaf64bd19c85e4c7081012dc7530 (patch)
tree3ca89f7ba1631632316946bbcbd6aad17960bf4b
parent935c7272ba0f17f81823e704b54627b75cf7f913 (diff)
downloadbundler-fixed-bundler-specs-on-ruby-repo.tar.gz
Fixed test failures with gem command path on ruby core repo.fixed-bundler-specs-on-ruby-repo
-rw-r--r--spec/bundler/gem_helper_spec.rb2
-rw-r--r--spec/commands/exec_spec.rb2
-rw-r--r--spec/support/path.rb6
-rw-r--r--spec/support/rubygems_ext.rb2
4 files changed, 8 insertions, 4 deletions
diff --git a/spec/bundler/gem_helper_spec.rb b/spec/bundler/gem_helper_spec.rb
index c01d65d5dd..29e10d64f8 100644
--- a/spec/bundler/gem_helper_spec.rb
+++ b/spec/bundler/gem_helper_spec.rb
@@ -235,7 +235,7 @@ RSpec.describe Bundler::GemHelper do
end
it "uses Kernel.system" do
- expect(Kernel).to receive(:system).with("gem", "push", app_gem_path.to_s, "--host", "http://example.org").and_return(true)
+ expect(Kernel).to receive(:system).with(gem_bin, "push", app_gem_path.to_s, "--host", "http://example.org").and_return(true)
Rake.application["release"].invoke
end
diff --git a/spec/commands/exec_spec.rb b/spec/commands/exec_spec.rb
index a5d67c6d68..c1d6e4c25a 100644
--- a/spec/commands/exec_spec.rb
+++ b/spec/commands/exec_spec.rb
@@ -57,7 +57,7 @@ RSpec.describe "bundle exec" do
it "works when exec'ing to rubygems" do
install_gemfile 'gem "rack"'
- bundle "exec gem --version"
+ bundle "exec #{gem_cmd} --version"
expect(out).to eq(Gem::VERSION)
end
diff --git a/spec/support/path.rb b/spec/support/path.rb
index eea3161b15..645da52c97 100644
--- a/spec/support/path.rb
+++ b/spec/support/path.rb
@@ -21,8 +21,12 @@ module Spec
@bindir ||= root.join(ruby_core? ? "libexec" : "exe")
end
+ def gem_cmd
+ @gem_cmd ||= ruby_core? ? root.join("bin/gem") : "gem"
+ end
+
def gem_bin
- @gem_bin ||= ruby_core? ? ENV["GEM_COMMAND"] : "#{Gem.ruby} -S gem --backtrace"
+ @gem_bin ||= ruby_core? ? ENV["GEM_COMMAND"] : "gem"
end
def spec_dir
diff --git a/spec/support/rubygems_ext.rb b/spec/support/rubygems_ext.rb
index 7e9e8328c5..ee9c750a52 100644
--- a/spec/support/rubygems_ext.rb
+++ b/spec/support/rubygems_ext.rb
@@ -99,7 +99,7 @@ module Spec
no_reqs.map!(&:first)
reqs.map! {|name, req| "'#{name}:#{req}'" }
deps = reqs.concat(no_reqs).join(" ")
- gem = Path.gem_bin
+ gem = ENV["GEM_COMMAND"] || "#{Gem.ruby} -S gem --backtrace"
cmd = "#{gem} install #{deps} --no-document --conservative"
system(cmd) || raise("Installing gems #{deps} for the tests to use failed!")
end