diff options
author | Colby Swandale <me@colby.fyi> | 2019-06-03 19:59:32 +1000 |
---|---|---|
committer | Colby Swandale <me@colby.fyi> | 2019-06-03 20:03:37 +1000 |
commit | 50c3395479ff9bca569212fbdc3a6e8743b92802 (patch) | |
tree | c9c7c975b1ae5a399d56433893f8071645acadca | |
parent | 1953cfdbd34b8f701ea2a330820b6bfb6b56c638 (diff) | |
download | bundler-colby/bundler-2-fix-git-https.tar.gz |
fix bug where bundler v3 is running a test for bundflet 2colby/bundler-2-fix-git-https
-rw-r--r-- | spec/other/major_deprecation_spec.rb | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/spec/other/major_deprecation_spec.rb b/spec/other/major_deprecation_spec.rb index 04f71e2eca..0a3c65a1e5 100644 --- a/spec/other/major_deprecation_spec.rb +++ b/spec/other/major_deprecation_spec.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.describe "major deprecations", :bundler => "< 3" do +RSpec.describe "major deprecations", :bundler => "<= 2" do let(:warnings) { last_command.bundler_err } # change to err in 2.0 let(:warnings_without_version_messages) { warnings.gsub(/#{Spec::Matchers::MAJOR_DEPRECATION}Bundler will only support ruby(gems)? >= .*/, "") } @@ -198,17 +198,6 @@ RSpec.describe "major deprecations", :bundler => "< 3" do end context "with github gems" do - it "warns about the https change", :bundler => "3" do - msg = <<-EOS -The :github git source is deprecated, and will be removed in Bundler 3.0. Change any "reponame" :github sources to "username/reponame". Add this code to the top of your Gemfile to ensure it continues to work: - - git_source(:github) {|repo_name| "https://github.com/\#{repo_name}.git" } - - EOS - expect(Bundler::SharedHelpers).to receive(:major_deprecation).with(3, msg) - subject.gem("sparks", :github => "indirect/sparks") - end - it "upgrades to https on request" do Bundler.settings.temporary "github.https" => true msg = <<-EOS |