summaryrefslogtreecommitdiff
path: root/.github/config.yml
diff options
context:
space:
mode:
authorBundlerbot <bot@bundler.io>2020-03-05 12:18:57 +0000
committerBundlerbot <bot@bundler.io>2020-03-05 12:18:57 +0000
commitc645636cc8e76a53772e3ab15693ed716132159a (patch)
treed50d99b9eabc864366d70981a42f7e9bb58a96d5 /.github/config.yml
parentb39df5e3b4f926fa8a928ae2fa0a2a9dcfe5eb33 (diff)
parentd36920f40dae8bb0cda7f4c14fc32fe30ea7fe0e (diff)
downloadbundler-c645636cc8e76a53772e3ab15693ed716132159a.tar.gz
Merge #7665
7665: Fix sudo specs environment r=hsbt a=deivid-rodriguez ### What was the end-user or developer problem that led to this PR? The developer problem is that sudo specs are not correctly setting the environment (except for ruby 2.3). The specs are accidentally passing but you can tell that they are running against the system ruby by the [warning messages they print](https://travis-ci.org/rubygems/bundler/jobs/658272719#L531-L558). This causes problems when migrating to github actions. See https://github.com/rubygems/bundler/pull/7660#discussion_r385616844. Another problem is that the environment is setup manually outside of `rake spec:sudo`, so there's no easy way of running sudo specs manually if your system does not have the right sudoers configuration. ### What is your fix for the problem, implemented in this PR? My fix is to properly set sudo configuration to preserve the environment so that the correct ruby can be found by sudo specs, and also to move the logic inside `rake spec:sudo` so that the specs can easily be run manually without side effects. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Diffstat (limited to '.github/config.yml')
0 files changed, 0 insertions, 0 deletions