summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin David <valentin.david@codethink.co.uk>2018-08-14 10:21:57 +0200
committerValentin David <valentin.david@gmail.com>2018-08-16 08:37:28 +0000
commitd6d502f209d826c80271a18811bcdad969fbbf2d (patch)
treeee8f33e97631ccb7c49201d8e375547501805e9b
parentac97bc5eaa00329da3589dbb49be116ba6d8e381 (diff)
downloadbuildstream-d6d502f209d826c80271a18811bcdad969fbbf2d.tar.gz
buildstream/plugins/sources/git.py: Fix clone side effect in getting fetchers
We now delay refreshing submodules until we have a clone, that is after we have fetched the main fetcher. Fixes #537
-rw-r--r--buildstream/plugins/sources/git.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py
index 073365bff..b3cf903bf 100644
--- a/buildstream/plugins/sources/git.py
+++ b/buildstream/plugins/sources/git.py
@@ -404,8 +404,10 @@ class GitSource(Source):
mirror.stage(directory)
def get_source_fetchers(self):
+ yield self.mirror
self.refresh_submodules()
- return [self.mirror] + self.submodules
+ for submodule in self.submodules:
+ yield submodule
###########################################################
# Local Functions #