From d6d502f209d826c80271a18811bcdad969fbbf2d Mon Sep 17 00:00:00 2001 From: Valentin David Date: Tue, 14 Aug 2018 10:21:57 +0200 Subject: buildstream/plugins/sources/git.py: Fix clone side effect in getting fetchers We now delay refreshing submodules until we have a clone, that is after we have fetched the main fetcher. Fixes #537 --- buildstream/plugins/sources/git.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/buildstream/plugins/sources/git.py b/buildstream/plugins/sources/git.py index 073365bff..b3cf903bf 100644 --- a/buildstream/plugins/sources/git.py +++ b/buildstream/plugins/sources/git.py @@ -404,8 +404,10 @@ class GitSource(Source): mirror.stage(directory) def get_source_fetchers(self): + yield self.mirror self.refresh_submodules() - return [self.mirror] + self.submodules + for submodule in self.submodules: + yield submodule ########################################################### # Local Functions # -- cgit v1.2.1