filter plugin: Stage the artifacts in Element.stage()

Staging artifacts at Element.assemble() time is now illegal

1 files changed, 2 insertions, 3 deletions

diff --git a/src/buildstream/plugins/elements/filter.py b/src/buildstream/plugins/elements/filter.py
index c817ca46b..783079c06 100644
--- a/src/buildstream/plugins/elements/filter.py
+++ b/src/buildstream/plugins/elements/filter.py
@@ -219,9 +219,6 @@ class FilterElement(Element):
         pass
 
     def stage(self, sandbox):
-        pass
-
-    def assemble(self, sandbox):
         with self.timed_activity("Staging artifact", silent_nested=True):
             for dep in self.dependencies(recurse=False):
                 # Check that all the included/excluded domains exist
@@ -250,6 +247,8 @@ class FilterElement(Element):
                     raise ElementError("Unknown domains declared.", detail=detail)
 
                 dep.stage_artifact(sandbox, include=self.include, exclude=self.exclude, orphans=self.include_orphans)
+
+    def assemble(self, sandbox):
         return ""
 
     def _get_source_element(self):