From eb0a8c2856f7291b44170dce6f67d9bc8b26b61c Mon Sep 17 00:00:00 2001 From: Tristan van Berkom Date: Thu, 10 Sep 2020 21:34:50 +0900 Subject: filter plugin: Stage the artifacts in Element.stage() Staging artifacts at Element.assemble() time is now illegal --- src/buildstream/plugins/elements/filter.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/buildstream/plugins/elements/filter.py b/src/buildstream/plugins/elements/filter.py index c817ca46b..783079c06 100644 --- a/src/buildstream/plugins/elements/filter.py +++ b/src/buildstream/plugins/elements/filter.py @@ -219,9 +219,6 @@ class FilterElement(Element): pass def stage(self, sandbox): - pass - - def assemble(self, sandbox): with self.timed_activity("Staging artifact", silent_nested=True): for dep in self.dependencies(recurse=False): # Check that all the included/excluded domains exist @@ -250,6 +247,8 @@ class FilterElement(Element): raise ElementError("Unknown domains declared.", detail=detail) dep.stage_artifact(sandbox, include=self.include, exclude=self.exclude, orphans=self.include_orphans) + + def assemble(self, sandbox): return "" def _get_source_element(self): -- cgit v1.2.1