summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Mewett <tom.mewett@codethink.co.uk>2019-08-08 11:22:44 +0100
committerbst-marge-bot <marge-bot@buildstream.build>2019-08-12 11:44:40 +0000
commitcded5549756cedf9620c89571b3864da963328dc (patch)
tree653d44aa86c71ed120939ac583544a80de066d6b
parentf7e56788bca1204b1a76ffb357db92b5994db22c (diff)
downloadbuildstream-tmewett/report-weird-return-codes.tar.gz
job.py: Report error when job process unexpectedly dies (#1089)tmewett/report-weird-return-codes
-rw-r--r--src/buildstream/_scheduler/jobs/job.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/buildstream/_scheduler/jobs/job.py b/src/buildstream/_scheduler/jobs/job.py
index 32c5559fb..7cbde2d39 100644
--- a/src/buildstream/_scheduler/jobs/job.py
+++ b/src/buildstream/_scheduler/jobs/job.py
@@ -449,7 +449,11 @@ class Job():
try:
returncode = _ReturnCode(returncode)
- except ValueError: # An unexpected return code was returned, let's fail permanently
+ except ValueError:
+ # An unexpected return code was returned; fail permanently and report
+ self.message(MessageType.ERROR,
+ "Internal job process unexpectedly died with exit code {}".format(returncode),
+ logfile=self._logfile)
returncode = _ReturnCode.PERM_FAIL
# We don't want to retry if we got OK or a permanent fail.