summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Ennis <james.ennis@codethink.com>2018-02-14 17:04:43 +0000
committerJames Ennis <james.ennis@codethink.com>2018-03-14 14:10:26 +0000
commitb11b48eadd3052d7e209ae7be8c513ca128099e3 (patch)
tree49f1f1bb27ae844160a72f7b01bead2e5752d542
parent81833add3730eb3f8b489e9f5cc34df7617373fc (diff)
downloadbuildstream-b11b48eadd3052d7e209ae7be8c513ca128099e3.tar.gz
pylint - dealt with unidiomatic-typecheck warning
-rw-r--r--.pylintrc3
-rw-r--r--buildstream/sandbox/_sandboxbwrap.py2
2 files changed, 1 insertions, 4 deletions
diff --git a/.pylintrc b/.pylintrc
index 5c72e53b7..a2d82164f 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -114,9 +114,6 @@ disable=#####################################
logging-format-interpolation,
- # Some of us like type() - should be discouraged
- unidiomatic-typecheck,
-
# We aren't fully compliant with pep8 import order yet
wrong-import-order,
wrong-import-position,
diff --git a/buildstream/sandbox/_sandboxbwrap.py b/buildstream/sandbox/_sandboxbwrap.py
index fc47be31e..f955a5e44 100644
--- a/buildstream/sandbox/_sandboxbwrap.py
+++ b/buildstream/sandbox/_sandboxbwrap.py
@@ -68,7 +68,7 @@ class SandboxBwrap(Sandbox):
env = self._get_environment()
# We want command args as a list of strings
- if type(command) == str:
+ if isinstance(command, str):
command = [command]
# Create the mount map, this will tell us where