From b11b48eadd3052d7e209ae7be8c513ca128099e3 Mon Sep 17 00:00:00 2001 From: James Ennis Date: Wed, 14 Feb 2018 17:04:43 +0000 Subject: pylint - dealt with unidiomatic-typecheck warning --- .pylintrc | 3 --- buildstream/sandbox/_sandboxbwrap.py | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.pylintrc b/.pylintrc index 5c72e53b7..a2d82164f 100644 --- a/.pylintrc +++ b/.pylintrc @@ -114,9 +114,6 @@ disable=##################################### logging-format-interpolation, - # Some of us like type() - should be discouraged - unidiomatic-typecheck, - # We aren't fully compliant with pep8 import order yet wrong-import-order, wrong-import-position, diff --git a/buildstream/sandbox/_sandboxbwrap.py b/buildstream/sandbox/_sandboxbwrap.py index fc47be31e..f955a5e44 100644 --- a/buildstream/sandbox/_sandboxbwrap.py +++ b/buildstream/sandbox/_sandboxbwrap.py @@ -68,7 +68,7 @@ class SandboxBwrap(Sandbox): env = self._get_environment() # We want command args as a list of strings - if type(command) == str: + if isinstance(command, str): command = [command] # Create the mount map, this will tell us where -- cgit v1.2.1