diff options
author | Akim Demaille <akim@lrde.epita.fr> | 2013-04-14 14:42:15 +0200 |
---|---|---|
committer | Akim Demaille <akim@lrde.epita.fr> | 2013-04-15 10:57:19 +0200 |
commit | c53b6848897960bc783afdbc230e1a247977d63d (patch) | |
tree | fcffea180f85890d3536b4f60595d85b94f5c4c7 /src | |
parent | 5fad4d4f094e866b211302f01d556b3bc93350be (diff) | |
download | bison-c53b6848897960bc783afdbc230e1a247977d63d.tar.gz |
muscle: enforce definition syntax for keyword variables
* src/muscle-tab.c (muscle_percent_define_get_kind)
(muscle_percent_define_check_kind): New.
(muscle_percent_define_default): Variables with a default value are
of "keyword" kind.
(muscle_percent_define_flag_if, muscle_percent_define_check_values):
Check that the variable is of keyword kind.
* data/bison.m4: Likewise, but in M4. That is to say...
(b4_percent_define_default): Define the kind when the variable is undefined.
(b4_percent_define_check_kind): Use a better error message.
(_b4_percent_define_check_values, _b4_percent_define_check_values):
Former "enum" variables should be defined using the keyword syntax.
* doc/bison.texi: Update.
A couple of fixes.
* tests/input.at (%define keyword variables): New.
Diffstat (limited to 'src')
-rw-r--r-- | src/muscle-tab.c | 39 |
1 files changed, 39 insertions, 0 deletions
diff --git a/src/muscle-tab.c b/src/muscle-tab.c index e11699f3..8925d228 100644 --- a/src/muscle-tab.c +++ b/src/muscle-tab.c @@ -579,6 +579,42 @@ muscle_percent_define_get (char const *variable) return value; } +/* The kind of VARIABLE. An error if undefined. */ +static muscle_kind +muscle_percent_define_get_kind (char const *variable) +{ + return muscle_kind_new (muscle_percent_define_get_raw (variable, "kind")); +} + +/* Check the kind of VARIABLE. An error if undefined. */ +static void +muscle_percent_define_check_kind (char const *variable, muscle_kind kind) +{ + if (muscle_percent_define_get_kind (variable) != kind) + { + location loc = muscle_percent_define_get_loc (variable); + switch (kind) + { + case muscle_code: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires '{...}' values", + variable); + break; + case muscle_keyword: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires keyword values", + variable); + break; + case muscle_string: + complain (&loc, Wdeprecated, + "%%define variable '%s' requires '\"...\"' values", + variable); + break; + } + } +} + + location muscle_percent_define_get_loc (char const *variable) { @@ -612,6 +648,7 @@ muscle_percent_define_flag_if (char const *variable) if (muscle_percent_define_ifdef (variable)) { char *value = muscle_percent_define_get (variable); + muscle_percent_define_check_kind (variable, muscle_keyword); if (value[0] == '\0' || STREQ (value, "true")) result = true; else if (STREQ (value, "false")) @@ -640,6 +677,7 @@ muscle_percent_define_default (char const *variable, char const *value) if (!muscle_find_const (name)) { MUSCLE_INSERT_STRING (name, value); + MUSCLE_INSERT_STRING (muscle_name (variable, "kind"), "keyword"); { uniqstr loc_name = muscle_name (variable, "loc"); location loc; @@ -661,6 +699,7 @@ muscle_percent_define_check_values (char const * const *values) char const * const *variablep = values; uniqstr name = muscle_name (*variablep, NULL); char *value = string_decode (name); + muscle_percent_define_check_kind (*variablep, muscle_keyword); if (value) { for (++values; *values; ++values) |