summaryrefslogtreecommitdiff
path: root/data/skeletons/yacc.c
diff options
context:
space:
mode:
authorAkim Demaille <akim.demaille@gmail.com>2020-05-31 12:56:02 +0200
committerAkim Demaille <akim.demaille@gmail.com>2020-06-01 08:29:53 +0200
commit52ce2a008bb32e686151c3c58739ff4fcd17f83d (patch)
treede19ece99ddacda0c6586771183f86116d170885 /data/skeletons/yacc.c
parent12f4091de4d0147354bad7a7fdca62d02014d410 (diff)
downloadbison-52ce2a008bb32e686151c3c58739ff4fcd17f83d.tar.gz
build: check -Wmissing-prototypes
pstate_clear is lacking a prototype. Reported by Ryan https://lists.gnu.org/r/bug-bison/2020-05/msg00101.html Besides, none of the C examples were compiled with the warning flags. * configure.ac (warn_c): Add -Wmissing-prototypes. * data/skeletons/yacc.c (pstate_clear): Make it static. * examples/local.mk (TEST_CFLAGS): New. * examples/c/bistromathic/local.mk, examples/c/calc/local.mk, * examples/c/lexcalc/local.mk, examples/c/mfcalc/local.mk, * examples/c/pushcalc/local.mk, examples/c/reccalc/local.mk, * examples/c/rpcalc/local.mk: Use it. GCC's warn_unused_result is not silenced by a cast to void, so we have to "use" scanf's result. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 Flex generated code produces too many warnings, including things such as, with ICC: examples/c/lexcalc/scan.c(1088): error #1682: implicit conversion of a 64-bit integral type to a smaller integral type (potential portability problem) 2259 YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), 2260 ^ 2261 2262 I am tired of trying to fix Flex's output. The project does not seem maintained. We ought to avoid it. So, for the time being, don't try to enable warnings with Flex. * examples/c/bistromathic/parse.y, examples/c/reccalc/scan.l: Fix warnings. * doc/bison.texi: Discard scanf's return value to defeat -Werror=unused-result.
Diffstat (limited to 'data/skeletons/yacc.c')
-rw-r--r--data/skeletons/yacc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/data/skeletons/yacc.c b/data/skeletons/yacc.c
index a9f15c8d..bd5e7d84 100644
--- a/data/skeletons/yacc.c
+++ b/data/skeletons/yacc.c
@@ -1480,7 +1480,7 @@ yypull_parse (yypstate *yyps]b4_user_formals[)
]b4_parse_state_variable_macros([b4_pstate_macro_define])[
/* Initialize the parser data structure. */
-void
+static void
yypstate_clear (yypstate *yyps)
{
]b4_initialize_parser_state_variables[