summaryrefslogtreecommitdiff
path: root/sim/ppc
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-10-12 11:14:26 +0100
committerAndrew Burgess <aburgess@redhat.com>2022-10-19 14:32:22 +0100
commite5961d2be503149aaa40927c0a9501c06ca980e5 (patch)
tree8615d42943528247618d2801ad4e78ed091a00f8 /sim/ppc
parent744875dfdc94dc397ae666c65c56b416c3a191db (diff)
downloadbinutils-gdb-e5961d2be503149aaa40927c0a9501c06ca980e5.tar.gz
sim/ppc: mark device_error function as ATTRIBUTE_NORETURN
The device_error function always ends up calling the error function, which is itself marked as ATTRIBUTE_NORETURN, so it makes sense that device_error should also be marked ATTRIBUTE_NORETURN. Doing this resolves a few warnings from hw_ide.c about possibly uninitialized variables - the variables are only uninitialized after passing through a call to device_error, which obviously means the variables are never really used uninitialized, the simulation will terminate with the device_error call.
Diffstat (limited to 'sim/ppc')
-rw-r--r--sim/ppc/device.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sim/ppc/device.h b/sim/ppc/device.h
index bd539095160..65c85e4ddd3 100644
--- a/sim/ppc/device.h
+++ b/sim/ppc/device.h
@@ -729,7 +729,7 @@ EXTERN_DEVICE\
(void) device_error
(device *me,
const char *fmt,
- ...) ATTRIBUTE_PRINTF_2;
+ ...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF_2;
INLINE_DEVICE\
(int) device_trace