diff options
| author | Jiawei <jiawei@iscas.ac.cn> | 2023-03-20 11:34:44 +0800 |
|---|---|---|
| committer | Nelson Chu <nelson@rivosinc.com> | 2023-03-21 17:47:47 +0800 |
| commit | e43d8768d909139bf5ec4a97c79a096ed28a4b08 (patch) | |
| tree | c687c4696bee3bf48b03aa964730d0155de04592 /opcodes | |
| parent | fec61519220148421595a21173f74401416d8d54 (diff) | |
| download | binutils-gdb-e43d8768d909139bf5ec4a97c79a096ed28a4b08.tar.gz | |
RISC-V: Fix disassemble fetch fail return value.
This bug reported in
https://sourceware.org/bugzilla/show_bug.cgi?id=30184
And discussed in
https://sourceware.org/pipermail/binutils/2023-February/126213.html
We also checked the implementation of return value in arm and mips.
So this patch changes the return value to -1, that can fix bugs and maintain
consistency with other architectures.
opcodes/ChangeLog:
* riscv-dis.c (print_insn_riscv):Change the return value.
Diffstat (limited to 'opcodes')
| -rw-r--r-- | opcodes/riscv-dis.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 7baba054daa..f431124b423 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -1059,7 +1059,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) if (status != 0) { (*info->memory_error_func) (status, memaddr, info); - return status; + return -1; } insn = (insn_t) bfd_getl16 (packet); dump_size = riscv_insn_length (insn); @@ -1071,7 +1071,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) if (status != 0) { (*info->memory_error_func) (status, memaddr, info); - return status; + return -1; } insn = (insn_t) bfd_get_bits (packet, dump_size * 8, false); |