diff options
| author | Nick Clifton <nickc@redhat.com> | 2023-03-03 13:56:36 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2023-03-03 13:56:36 +0000 |
| commit | adbe951fc95943016325af08d677f18e8c177ac1 (patch) | |
| tree | 6f2e0031aab67fa63ea904a65470e025688d6578 /ld | |
| parent | 6a208145d24c47912c8beb4f1f4b9abeb8d51134 (diff) | |
| download | binutils-gdb-adbe951fc95943016325af08d677f18e8c177ac1.tar.gz | |
Prevent the ASCII linker script directive from generating huge amounts of padding if the size expression is not a constant.
PR 30193 * ldgram.y (ASCII): Fail if the size is not a constant.
Diffstat (limited to 'ld')
| -rw-r--r-- | ld/ChangeLog | 5 | ||||
| -rw-r--r-- | ld/ldgram.y | 5 |
2 files changed, 9 insertions, 1 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog index 9f4ad7cbf25..6a7bc06c70c 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,8 @@ +2023-03-03 Nick Clifton <nickc@redhat.com> + + PR 30193 + * ldgram.y (ASCII): Fail if the size is not a constant. + 2023-02-23 Fangrui Song <i@maskray.me> * emultempl/riscvelf.em: Add option parsing. diff --git a/ld/ldgram.y b/ld/ldgram.y index faffeec94b8..26e56fe1566 100644 --- a/ld/ldgram.y +++ b/ld/ldgram.y @@ -672,7 +672,10 @@ statement: { /* 'value' is a memory leak, do we care? */ etree_type *value = $3; - lang_add_string (value->value.value, $5); + if (value->type.node_code == INT) + lang_add_string (value->value.value, $5); + else + einfo (_("%X%P:%pS: ASCII expression must be an integer\n"), NULL); } | ASCIZ NAME { |