diff options
| author | Alan Modra <amodra@gmail.com> | 2023-02-06 12:46:52 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2023-02-06 23:06:44 +1030 |
| commit | 84789002905d6db444ee76431705c86cbcde5616 (patch) | |
| tree | d5c9a4c3dcff7456e90d19643cdac3076567cdaf /ld | |
| parent | 9af467b82406614deb46151f838c336a7c8604db (diff) | |
| download | binutils-gdb-84789002905d6db444ee76431705c86cbcde5616.tar.gz | |
ppc32 and "LOAD segment with RWX permissions"
When using a bss-plt we'll always trigger the RWX warning, which
disturbs gcc test results. On the other hand, there may be reason to
want the warning when gcc is configured with --enable-secureplt.
So turning off the warning entirely for powerpc might not be the best
solution. Instead, we'll turn off the warning whenever a bss-plt is
generated, unless the user explicitly asked for the warning.
bfd/
* elf32-ppc.c (ppc_elf_select_plt_layout): Set
no_warn_rwx_segments on generating a bss plt, unless explicity
enabled by the user. Also show the bss-plt warning when
--warn-rwx-segments is given without --bss-plt.
include/
* bfdlink.h (struct bfd_link_info): Add user_warn_rwx_segments.
ld/
* lexsup.c (parse_args): Set user_warn_rwx_segments.
* testsuite/ld-elf/elf.exp: Pass --secure-plt for powerpc to
the rwx tests.
Diffstat (limited to 'ld')
| -rw-r--r-- | ld/lexsup.c | 2 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/elf.exp | 8 |
2 files changed, 10 insertions, 0 deletions
diff --git a/ld/lexsup.c b/ld/lexsup.c index c5960385572..a1c6140100d 100644 --- a/ld/lexsup.c +++ b/ld/lexsup.c @@ -936,9 +936,11 @@ parse_args (unsigned argc, char **argv) break; case OPTION_WARN_RWX_SEGMENTS: link_info.no_warn_rwx_segments = 0; + link_info.user_warn_rwx_segments = 1; break; case OPTION_NO_WARN_RWX_SEGMENTS: link_info.no_warn_rwx_segments = 1; + link_info.user_warn_rwx_segments = 1; break; case 'e': lang_add_entry (optarg, true); diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp index 1a160d084e0..a4f7f60fefc 100644 --- a/ld/testsuite/ld-elf/elf.exp +++ b/ld/testsuite/ld-elf/elf.exp @@ -238,6 +238,12 @@ if { [istarget *-*-*linux*] return $text } + set curr_ldflags $LDFLAGS + if { [istarget powerpc*-*-*] && ![istarget powerpc64*-*-*] } { + # Don't generate an executable .plt section + set LDFLAGS "$LDFLAGS --secure-plt" + } + # Since the warnings can be disabled by configure, ensure consistency # of the first test by forcing the flags. run_ld_link_tests [list \ @@ -285,6 +291,8 @@ if { [istarget *-*-*linux*] "rwx-segments-3.exe"] \ ] + set LDFLAGS $curr_ldflags + if { [target_defaults_to_execstack] } { run_ld_link_tests [list \ [list "PR ld/29072 (warn about absent .note.GNU-stack)" \ |