diff options
author | Alan Modra <amodra@gmail.com> | 2021-02-13 09:51:17 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2021-02-14 22:34:27 +1030 |
commit | 5b1f6c95704da7128ca2a7c682a2e0ef533180ce (patch) | |
tree | 0b17c5490260475e9df6d86e756656257a926e16 /ld/testsuite/ld-sh | |
parent | f5b2658b0fbef02a855b7bb7288de051cc687237 (diff) | |
download | binutils-gdb-5b1f6c95704da7128ca2a7c682a2e0ef533180ce.tar.gz |
ld testsuite: change unresolved to unsupported/fail
"unresolved" as a test result means runtest returns an error, which
can be confusing when there is no apparent error unless you look in
.log files. In particular many tests are skipped without reporting an
error if no target C compiler is found, but if a target C compiler is
found but won't compile a testcase for some reason we used to mark the
test as unresolved. Which is no more worthy of an error than when
lacking a C compiler entirely.
* testsuite/ld-cdtest/cdtest.exp,
* testsuite/ld-checks/checks.exp,
* testsuite/ld-elf/binutils.exp,
* testsuite/ld-elf/compress.exp,
* testsuite/ld-elf/dwarf.exp,
* testsuite/ld-elf/exclude.exp,
* testsuite/ld-elf/frame.exp,
* testsuite/ld-elf/indirect.exp,
* testsuite/ld-elf/linux-x86.exp,
* testsuite/ld-elf/sec-to-seg.exp,
* testsuite/ld-elf/tls_common.exp,
* testsuite/ld-elfcomm/elfcomm.exp,
* testsuite/ld-elfvers/vers.exp,
* testsuite/ld-elfvsb/elfvsb.exp,
* testsuite/ld-elfweak/elfweak.exp,
* testsuite/ld-ifunc/binutils.exp,
* testsuite/ld-mips-elf/mips-elf-flags.exp,
* testsuite/ld-misc/defsym.exp,
* testsuite/ld-mn10300/mn10300.exp,
* testsuite/ld-plugin/lto.exp,
* testsuite/ld-plugin/plugin.exp,
* testsuite/ld-scripts/align.exp,
* testsuite/ld-scripts/assert.exp,
* testsuite/ld-scripts/crossref.exp,
* testsuite/ld-scripts/defined.exp,
* testsuite/ld-scripts/extern.exp,
* testsuite/ld-scripts/log2.exp,
* testsuite/ld-scripts/map-address.exp,
* testsuite/ld-scripts/phdrs.exp,
* testsuite/ld-scripts/phdrs2.exp,
* testsuite/ld-scripts/script.exp,
* testsuite/ld-scripts/section-flags.exp,
* testsuite/ld-scripts/sizeof.exp,
* testsuite/ld-scripts/weak.exp,
* testsuite/ld-selective/selective.exp,
* testsuite/ld-sh/sh.exp,
* testsuite/ld-shared/shared.exp,
* testsuite/ld-srec/srec.exp,
* testsuite/ld-tic6x/tic6x.exp,
* testsuite/ld-undefined/undefined.exp,
* testsuite/ld-undefined/weak-undef.exp,
* testsuite/lib/ld-lib.exp: Don't use unresolved except after
perror. Instead report "unsupported" or "fail".
Diffstat (limited to 'ld/testsuite/ld-sh')
-rw-r--r-- | ld/testsuite/ld-sh/sh.exp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/ld/testsuite/ld-sh/sh.exp b/ld/testsuite/ld-sh/sh.exp index 4ba35f264bf..78905f0d89b 100644 --- a/ld/testsuite/ld-sh/sh.exp +++ b/ld/testsuite/ld-sh/sh.exp @@ -31,7 +31,7 @@ if ![istarget sh*-*-*] { set testsimple "SH simple relaxing" if { ![is_elf_format] } { - unresolved $testsimple + unsupported $testsimple } elseif { ![ld_assemble $as "-relax $srcdir/$subdir/sh1.s" tmpdir/sh1.o] } { fail $testsimple } elseif { ![ld_link $ld tmpdir/sh1 "-relax tmpdir/sh1.o"] } { @@ -56,7 +56,7 @@ if { ![is_elf_format] } { set testsrec "SH relaxing to S-records" if { ![remote_file host exists tmpdir/sh1] } { - unresolved $testsrec + unsupported $testsrec } else { if { [istarget sh*-linux-*] || [istarget sh-*-vxworks] } { # On these "non-embedded" targets, the default ELF and srec start @@ -79,7 +79,7 @@ if { ![remote_file host exists tmpdir/sh1] } { if ![string match "" $exec_output] { send_log "$exec_output\n" verbose "$exec_output" - unresolved $testsrec + fail $testsrec } else { send_log "$objcopy -O srec tmpdir/sh1 tmpdir/sh1.s1\n" verbose "$objcopy -O srec tmpdir/sh1 tmpdir/sh1.s1" @@ -87,7 +87,7 @@ if { ![remote_file host exists tmpdir/sh1] } { if ![string match "" $exec_output] { send_log "$exec_output\n" verbose "$exec_output" - unresolved $testsrec + fail $testsrec } else { send_log "cmp tmpdir/sh1.s1 tmpdir/sh1.s2\n" verbose "cmp tmpdir/sh1.s1 tmpdir/sh1.s2" @@ -107,7 +107,7 @@ if { ![remote_file host exists tmpdir/sh1] } { set testadjsw8 "SH switch8 adjustment after relax" if { ![is_elf_format] } { - unresolved $testadjsw8 + unsupported $testadjsw8 } elseif { ![ld_assemble $as "-relax $srcdir/$subdir/adjsw8.s" tmpdir/adjsw8.o] } { fail $testadjsw8 } elseif { ![ld_link $ld tmpdir/adjsw8 "-relax tmpdir/adjsw8.o"] } { @@ -145,16 +145,16 @@ if [istarget sh*-*linux*] { if {![ld_assemble $as "-relax tmpdir/start.s" tmpdir/start.o] \ || ![ld_compile $CC "-O -mrelax -foptimize-sibling-calls $srcdir/$subdir/sh2.c" tmpdir/sh2.o]} { - unresolved $testlink - unresolved $testjsr - unresolved $testrun + unsupported $testlink + unsupported $testjsr + unsupported $testrun return } if ![ld_link $ld tmpdir/sh2 "-relax tmpdir/start.o tmpdir/sh2.o"] { fail $testlink - unresolved $testjsr - unresolved $testrun + unsupported $testjsr + unsupported $testrun return } |