diff options
author | Alan Modra <amodra@gmail.com> | 2021-02-13 09:51:17 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2021-02-14 22:34:27 +1030 |
commit | 5b1f6c95704da7128ca2a7c682a2e0ef533180ce (patch) | |
tree | 0b17c5490260475e9df6d86e756656257a926e16 /ld/testsuite/ld-elfvers | |
parent | f5b2658b0fbef02a855b7bb7288de051cc687237 (diff) | |
download | binutils-gdb-5b1f6c95704da7128ca2a7c682a2e0ef533180ce.tar.gz |
ld testsuite: change unresolved to unsupported/fail
"unresolved" as a test result means runtest returns an error, which
can be confusing when there is no apparent error unless you look in
.log files. In particular many tests are skipped without reporting an
error if no target C compiler is found, but if a target C compiler is
found but won't compile a testcase for some reason we used to mark the
test as unresolved. Which is no more worthy of an error than when
lacking a C compiler entirely.
* testsuite/ld-cdtest/cdtest.exp,
* testsuite/ld-checks/checks.exp,
* testsuite/ld-elf/binutils.exp,
* testsuite/ld-elf/compress.exp,
* testsuite/ld-elf/dwarf.exp,
* testsuite/ld-elf/exclude.exp,
* testsuite/ld-elf/frame.exp,
* testsuite/ld-elf/indirect.exp,
* testsuite/ld-elf/linux-x86.exp,
* testsuite/ld-elf/sec-to-seg.exp,
* testsuite/ld-elf/tls_common.exp,
* testsuite/ld-elfcomm/elfcomm.exp,
* testsuite/ld-elfvers/vers.exp,
* testsuite/ld-elfvsb/elfvsb.exp,
* testsuite/ld-elfweak/elfweak.exp,
* testsuite/ld-ifunc/binutils.exp,
* testsuite/ld-mips-elf/mips-elf-flags.exp,
* testsuite/ld-misc/defsym.exp,
* testsuite/ld-mn10300/mn10300.exp,
* testsuite/ld-plugin/lto.exp,
* testsuite/ld-plugin/plugin.exp,
* testsuite/ld-scripts/align.exp,
* testsuite/ld-scripts/assert.exp,
* testsuite/ld-scripts/crossref.exp,
* testsuite/ld-scripts/defined.exp,
* testsuite/ld-scripts/extern.exp,
* testsuite/ld-scripts/log2.exp,
* testsuite/ld-scripts/map-address.exp,
* testsuite/ld-scripts/phdrs.exp,
* testsuite/ld-scripts/phdrs2.exp,
* testsuite/ld-scripts/script.exp,
* testsuite/ld-scripts/section-flags.exp,
* testsuite/ld-scripts/sizeof.exp,
* testsuite/ld-scripts/weak.exp,
* testsuite/ld-selective/selective.exp,
* testsuite/ld-sh/sh.exp,
* testsuite/ld-shared/shared.exp,
* testsuite/ld-srec/srec.exp,
* testsuite/ld-tic6x/tic6x.exp,
* testsuite/ld-undefined/undefined.exp,
* testsuite/ld-undefined/weak-undef.exp,
* testsuite/lib/ld-lib.exp: Don't use unresolved except after
perror. Instead report "unsupported" or "fail".
Diffstat (limited to 'ld/testsuite/ld-elfvers')
-rw-r--r-- | ld/testsuite/ld-elfvers/vers.exp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/ld/testsuite/ld-elfvers/vers.exp b/ld/testsuite/ld-elfvers/vers.exp index 5dbe5dccfb4..8a1383fe840 100644 --- a/ld/testsuite/ld-elfvers/vers.exp +++ b/ld/testsuite/ld-elfvers/vers.exp @@ -105,7 +105,7 @@ proc test_ar { test lib object expect } { set exec_output [prune_warnings $exec_output] if ![string match "" $exec_output] { verbose -log "$exec_output" - unresolved "$test" + fail "$test" return } @@ -493,12 +493,12 @@ proc build_binary { shared pic test source libname other mapfile verexp versymex global NOLTO_CFLAGS if ![ld_compile "$CC -S $pic $CFLAGS $NOSANITIZE_CFLAGS $NOLTO_CFLAGS" $srcdir/$subdir/$source $tmpdir/$libname.s] { - unresolved "$test" + unsupported "$test" return } if ![ld_assemble $as "$as_options $tmpdir/$libname.s" $tmpdir/$libname.o ] { - unresolved "$test" + unsupported "$test" return } @@ -589,12 +589,12 @@ proc test_ldfail { test flag source execname other mapfile whyfail } { } if ![ld_compile "$CC -S $flag $CFLAGS" $srcdir/$subdir/$source $tmpdir/$execname.s] { - unresolved "$test" + unsupported "$test" return } if ![ld_assemble $as "$as_options $tmpdir/$execname.s" $tmpdir/$execname.o ] { - unresolved "$test" + unsupported "$test" return } @@ -623,7 +623,7 @@ proc test_asfail { test flag source execname whyfail } { global NOLTO_CFLAGS if ![ld_compile "$CC -S $flag $CFLAGS $NOLTO_CFLAGS" $srcdir/$subdir/$source $tmpdir/$execname.s] { - unresolved "$test" + unsupported "$test" return } @@ -706,12 +706,12 @@ proc build_exec { test source execname flags solibname verexp versymexp symexp } append cc_cmd " $NOSANITIZE_CFLAGS $NOLTO_CFLAGS" if ![ld_compile $cc_cmd $srcdir/$subdir/$source $tmpdir/$execname.s] { - unresolved "$test" + unsupported "$test" return } if ![ld_assemble $as "$as_options $tmpdir/$execname.s" $tmpdir/$execname.o ] { - unresolved "$test" + unsupported "$test" return } |