summaryrefslogtreecommitdiff
path: root/ld/ldver.h
diff options
context:
space:
mode:
authorMartin Storsjö <martin@martin.st>2022-09-06 18:39:07 +0300
committerMartin Storsjö <martin@martin.st>2022-09-12 11:07:35 +0300
commit825a844fdcfd4532cddde14d7bb38f1f981fa9fe (patch)
tree7a0e6ab9ef7c9bc1fbac6a8abbadef4c28453cce /ld/ldver.h
parenta33a94cf432e449461b7ddcc22b6f5a886cd3315 (diff)
downloadbinutils-gdb-825a844fdcfd4532cddde14d7bb38f1f981fa9fe.tar.gz
ld: pe: Apply review suggestions on the existing exports/imports arrays
Use a separate explicit max_exports/imports field, instead of deducing it from the number of allocated elements. Use a named constant for the incremental growth of the array. Use bool instead of int for boolean values. Remove an unnecessary if statement/scope in the def_file_free function. Add more verbose comments about parameters, and about insertion into an array of structs. Generally use unsigned integers for all array indices and sizes. The num_exports/imports fields are kept as is as signed integers, since changing them to unsigned would require a disproportionate amount of changes ti pe-dll.c to avoid comparisons between signed and unsigned. Simply use xrealloc instead of a check and xmalloc/xrealloc; xrealloc can take NULL as the first parameter (and does a similar check internally). (This wasn't requested in review though, but noticed while working on the code.)
Diffstat (limited to 'ld/ldver.h')
0 files changed, 0 insertions, 0 deletions