diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2012-12-03 14:34:06 +0000 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2012-12-03 14:34:06 +0000 |
| commit | d82184d78220ce42e0f54ce9fbb0688860ff0388 (patch) | |
| tree | 1546be4daa2443faede76fa4131484e4fc13b347 /ld/ldmain.c | |
| parent | dc9589e9756c8719b355472080fa8095a0ba68a7 (diff) | |
| download | binutils-gdb-d82184d78220ce42e0f54ce9fbb0688860ff0388.tar.gz | |
Improve plugin error handling
ld/
PR ld/14904
* ldmain.c (main): Don't check plugin_load_plugins return.
* lexsup.c (parse_args): Don't check plugin_opt_plugin return.
* plugin.c (dlerror): New. Defined if HAVE_DLFCN_H isn't
defined.
(plugin_opt_plugin): Change return type to void. Stop on
dlopen error and report error with dlerror ().
(plugin_load_plugins): Change return type to void. Stop on
dlsym error and report error with dlerror (). Don't use
set_plugin_error.
(plugin_call_cleanup): Issue an error for each plugin.
* plugin.h (plugin_opt_plugin): Change return type to void.
(plugin_load_plugins): Likewise.
ld/testsuite/
PR ld/14904
* ld-plugin/plugin-2.d: Update expected error message.
* ld-plugin/plugin-4.d: Likewise.
Diffstat (limited to 'ld/ldmain.c')
| -rw-r--r-- | ld/ldmain.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ld/ldmain.c b/ld/ldmain.c index 07f5f0923de..c23c55444e4 100644 --- a/ld/ldmain.c +++ b/ld/ldmain.c @@ -308,8 +308,7 @@ main (int argc, char **argv) #ifdef ENABLE_PLUGINS /* Now all the plugin arguments have been gathered, we can load them. */ - if (plugin_load_plugins ()) - einfo (_("%P%F: %s: error loading plugin\n"), plugin_error_plugin ()); + plugin_load_plugins (); #endif /* ENABLE_PLUGINS */ ldemul_set_symbols (); |