diff options
| author | Vladimir Mezentsev <vladimir.mezentsev@oracle.com> | 2022-12-19 01:01:04 -0800 |
|---|---|---|
| committer | Vladimir Mezentsev <vladimir.mezentsev@oracle.com> | 2022-12-19 17:02:29 -0800 |
| commit | 309b9a1abf77d9c643206f512d3db3ed7a23b854 (patch) | |
| tree | 038b664167142959ea9df213b52143e509b5cf76 /gprofng/libcollector | |
| parent | bd1473135af24ca37e3871771c6aaf4541c6987d (diff) | |
| download | binutils-gdb-309b9a1abf77d9c643206f512d3db3ed7a23b854.tar.gz | |
gprofng: PR29646 Various warnings
gprofng/ChangeLog
2022-12-19 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
PR gprofng/29646
* common/core_pcbe.c: Fix missingReturn warning.
* libcollector/iolib.c: Fix -Waddress warnings.
* src/Settings.cc: Likewise.
* src/checks.cc: Likewise.
* libcollector/linetrace.c: Likewise.
* libcollector/iotrace.c: Fix va_end_missing error.
* libcollector/libcol_util.c: Fix uninitvar warning.
* src/Command.cc: Fix arrayIndexOutOfBounds error.
* src/Function.cc: Fix uninitStructMember warning.
* src/ipc.cc: Fix -Wwrite-strings warnings.
Diffstat (limited to 'gprofng/libcollector')
| -rw-r--r-- | gprofng/libcollector/iolib.c | 2 | ||||
| -rw-r--r-- | gprofng/libcollector/iotrace.c | 7 | ||||
| -rw-r--r-- | gprofng/libcollector/libcol_util.c | 2 | ||||
| -rw-r--r-- | gprofng/libcollector/linetrace.c | 2 |
4 files changed, 9 insertions, 4 deletions
diff --git a/gprofng/libcollector/iolib.c b/gprofng/libcollector/iolib.c index 861843c183d..5f09b0e4cd1 100644 --- a/gprofng/libcollector/iolib.c +++ b/gprofng/libcollector/iolib.c @@ -148,7 +148,7 @@ __collector_create_handle (char *descp) init (); /* set up header for file, file name, etc. */ - if (__collector_exp_dir_name == NULL) + if (*__collector_exp_dir_name == 0) { __collector_log_write ("<event kind=\"%s\" id=\"%d\">__collector_exp_dir_name==NULL</event>\n", SP_JCMD_CERROR, COL_ERROR_EXPOPEN); diff --git a/gprofng/libcollector/iotrace.c b/gprofng/libcollector/iotrace.c index e7e8afa307d..466bf457b75 100644 --- a/gprofng/libcollector/iotrace.c +++ b/gprofng/libcollector/iotrace.c @@ -2713,10 +2713,15 @@ fprintf (FILE *stream, const char *format, ...) if (NULL_PTR (vfprintf)) init_io_intf (); if (CHCK_REENTRANCE (guard) || stream == NULL) - return CALL_REAL (vfprintf)(stream, format, ap); + { + ret = CALL_REAL (vfprintf)(stream, format, ap); + va_end (ap); + return ret; + } PUSH_REENTRANCE (guard); hrtime_t reqt = gethrtime (); ret = CALL_REAL (vfprintf)(stream, format, ap); + va_end (ap); if (RECHCK_REENTRANCE (guard)) { POP_REENTRANCE (guard); diff --git a/gprofng/libcollector/libcol_util.c b/gprofng/libcollector/libcol_util.c index d682aa0ab29..454f45bba00 100644 --- a/gprofng/libcollector/libcol_util.c +++ b/gprofng/libcollector/libcol_util.c @@ -137,7 +137,7 @@ atomic_swap (volatile int * p, int v) int __collector_mutex_lock (collector_mutex_t *lock_var) { - volatile unsigned int i; /* xxxx volatile may not be honored on amd64 -x04 */ + volatile unsigned int i = 0; /* xxxx volatile may not be honored on amd64 -x04 */ if (!(*lock_var) && !atomic_swap (lock_var, 1)) return 0; diff --git a/gprofng/libcollector/linetrace.c b/gprofng/libcollector/linetrace.c index d67a66a3734..e974c97ec9b 100644 --- a/gprofng/libcollector/linetrace.c +++ b/gprofng/libcollector/linetrace.c @@ -832,7 +832,7 @@ linetrace_ext_fork_epilogue (const char *variant, const pid_t ret, char * n_line const char *params = CALL_UTIL (getenv)(SP_COLLECTOR_PARAMS); int ret; - if (new_exp_name == NULL) + if (*new_exp_name == 0) TprintfT (DBG_LT0, "linetrace_ext_fork_epilogue: ERROR: getenv(%s) undefined -- new expt aborted!\n", SP_COLLECTOR_EXPNAME); else if (params == NULL) |