Overhaul relocation framework to support overflow checking.

gold/
	PR gold/18695
	* reloc.h (Relocate_functions::Address): New typedef.
	(Relocate_functions::Addendtype): New typedef.
	(Relocate_functions::Overflow_check): New enum type.
	(Relocate_functions::Reloc_status): New enum type.
	(Relocate_functions::check_overflow): New function template.
	(Relocate_functions::rel): Add check parameter; check for overflow.
	(Relocate_functions::rel_unaligned): Likewise.
	(Relocate_functions::rela): Likewise.
	(Relocate_functions::pcrel): Likewise.
	(Relocate_functions::pcrel_unaligned): Likewise.
	(Relocate_functions::pcrela): Likewise.
	(Relocate_functions::rel8): Adjust parameter types.
	(Relocate_functions::rela8): Likewise.
	(Relocate_functions::pcrel8): Likewise.
	(Relocate_functions::pcrela8): Likewise.
	(Relocate_functions::rel16): Likewise.
	(Relocate_functions::rela168): Likewise.
	(Relocate_functions::pcrel16): Likewise.
	(Relocate_functions::pcrela16): Likewise.
	(Relocate_functions::rel32): Likewise.
	(Relocate_functions::rel32_unaligned): Likewise.
	(Relocate_functions::rela32): Likewise.
	(Relocate_functions::pcrel32): Likewise.
	(Relocate_functions::pcrel32_unaligned): Likewise.
	(Relocate_functions::pcrela32): Likewise.
	(Relocate_functions::rel8_check): New function.
	(Relocate_functions::rela8_check): New function.
	(Relocate_functions::pcrel8_check): New function.
	(Relocate_functions::pcrela8_check): New function.
	(Relocate_functions::rel16_check): New function.
	(Relocate_functions::rela168_check): New function.
	(Relocate_functions::pcrel16_check): New function.
	(Relocate_functions::pcrela16_check): New function.
	(Relocate_functions::rel32_check): New function.
	(Relocate_functions::rel32_unaligned_check): New function.
	(Relocate_functions::rela32_check): New function.
	(Relocate_functions::pcrel32_check): New function.
	(Relocate_functions::pcrel32_unaligned_check): New function.
	(Relocate_functions::pcrela32_check): New function.
	(Bits::has_unsigned_overflow32): New function.
	(Bits::has_unsigned_overflow): New function.
	* testsuite/Makefile.am (overflow_unittest): New test.
	* testsuite/Makefile.in: Regenerate.
	* testsuite/overflow_unittest.cc: New source file.

1 files changed, 139 insertions, 0 deletions

diff --git a/gold/testsuite/overflow_unittest.cc b/gold/testsuite/overflow_unittest.cc
new file mode 100644
index 00000000000..e33e012b59e
--- /dev/null
+++ b/gold/testsuite/overflow_unittest.cc
@@ -0,0 +1,139 @@
+// overflow_unittest.cc -- test functions that check for overflow.
+
+// Copyright (C) 2016 Free Software Foundation, Inc.
+// Written by Cary Coutant <ccoutant@google.com>.
+
+// This file is part of gold.
+
+// This program is free software; you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation; either version 3 of the License, or
+// (at your option) any later version.
+
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the Free Software
+// Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
+// MA 02110-1301, USA.
+
+#include "gold.h"
+#include "reloc.h"
+
+#include <sys/types.h>
+
+#include "test.h"
+
+namespace gold_testsuite
+{
+
+using namespace gold;
+
+bool
+Overflow_test(Test_report*)
+{
+  CHECK(! Bits<16>::has_unsigned_overflow(0ULL));
+  CHECK(! Bits<16>::has_unsigned_overflow(1ULL));
+  CHECK(! Bits<16>::has_unsigned_overflow(0x7fffULL));
+  CHECK(! Bits<16>::has_unsigned_overflow(0x8000ULL));
+  CHECK(! Bits<16>::has_unsigned_overflow(0x8001ULL));
+  CHECK(! Bits<16>::has_unsigned_overflow(0xffffULL));
+  CHECK(Bits<16>::has_unsigned_overflow(0x10000ULL));
+  CHECK(Bits<16>::has_unsigned_overflow(0x10001ULL));
+  CHECK(Bits<16>::has_unsigned_overflow(~0ULL));
+  CHECK(Bits<16>::has_unsigned_overflow(~0x7fffULL + 1));
+  CHECK(Bits<16>::has_unsigned_overflow(~0x8000ULL + 1));
+  CHECK(Bits<16>::has_unsigned_overflow(~0x8001ULL + 1));
+  CHECK(Bits<16>::has_unsigned_overflow(~0xffffULL + 1));
+  CHECK(Bits<16>::has_unsigned_overflow(~0x10000ULL + 1));
+  CHECK(Bits<16>::has_unsigned_overflow(~0x10001ULL + 1));
+
+  CHECK(! Bits<16>::has_overflow(0ULL));
+  CHECK(! Bits<16>::has_overflow(1ULL));
+  CHECK(! Bits<16>::has_overflow(0x7fffULL));
+  CHECK(Bits<16>::has_overflow(0x8000ULL));
+  CHECK(Bits<16>::has_overflow(0x8001ULL));
+  CHECK(Bits<16>::has_overflow(0xffffULL));
+  CHECK(Bits<16>::has_overflow(0x10000ULL));
+  CHECK(Bits<16>::has_overflow(0x10001ULL));
+  CHECK(! Bits<16>::has_overflow(~0ULL));
+  CHECK(! Bits<16>::has_overflow(~0x7fffULL + 1));
+  CHECK(! Bits<16>::has_overflow(~0x8000ULL + 1));
+  CHECK(Bits<16>::has_overflow(~0x8001ULL + 1));
+  CHECK(Bits<16>::has_overflow(~0xffffULL + 1));
+  CHECK(Bits<16>::has_overflow(~0x10000ULL + 1));
+  CHECK(Bits<16>::has_overflow(~0x10001ULL + 1));
+
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(0ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(1ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(0x7fffULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(0x8000ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(0x8001ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(0xffffULL));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(0x10000ULL));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(0x10001ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(~0ULL));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(~0x7fffULL + 1));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow64(~0x8000ULL + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(~0x8001ULL + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(~0xffffULL + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(~0x10000ULL + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow64(~0x10001ULL + 1));
+
+  CHECK(! Bits<16>::has_unsigned_overflow32(0U));
+  CHECK(! Bits<16>::has_unsigned_overflow32(1U));
+  CHECK(! Bits<16>::has_unsigned_overflow32(0x7fffU));
+  CHECK(! Bits<16>::has_unsigned_overflow32(0x8000U));
+  CHECK(! Bits<16>::has_unsigned_overflow32(0x8001U));
+  CHECK(! Bits<16>::has_unsigned_overflow32(0xffffU));
+  CHECK(Bits<16>::has_unsigned_overflow32(0x10000U));
+  CHECK(Bits<16>::has_unsigned_overflow32(0x10001U));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0U));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0x7fffU + 1));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0x8000U + 1));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0x8001U + 1));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0xffffU + 1));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0x10000U + 1));
+  CHECK(Bits<16>::has_unsigned_overflow32(~0x10001U + 1));
+
+  CHECK(! Bits<16>::has_overflow32(0U));
+  CHECK(! Bits<16>::has_overflow32(1U));
+  CHECK(! Bits<16>::has_overflow32(0x7fffU));
+  CHECK(Bits<16>::has_overflow32(0x8000U));
+  CHECK(Bits<16>::has_overflow32(0x8001U));
+  CHECK(Bits<16>::has_overflow32(0xffffU));
+  CHECK(Bits<16>::has_overflow32(0x10000U));
+  CHECK(Bits<16>::has_overflow32(0x10001U));
+  CHECK(! Bits<16>::has_overflow32(~0U));
+  CHECK(! Bits<16>::has_overflow32(~0x7fffU + 1));
+  CHECK(! Bits<16>::has_overflow32(~0x8000U + 1));
+  CHECK(Bits<16>::has_overflow32(~0x8001U + 1));
+  CHECK(Bits<16>::has_overflow32(~0xffffU + 1));
+  CHECK(Bits<16>::has_overflow32(~0x10000U + 1));
+  CHECK(Bits<16>::has_overflow32(~0x10001U + 1));
+
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(0U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(1U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(0x7fffU));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(0x8000U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(0x8001U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(0xffffU));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(0x10000U));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(0x10001U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(~0U));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(~0x7fffU + 1));
+  CHECK(! Bits<16>::has_signed_unsigned_overflow32(~0x8000U + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(~0x8001U + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(~0xffffU + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(~0x10000U + 1));
+  CHECK(Bits<16>::has_signed_unsigned_overflow32(~0x10001U + 1));
+
+  return true;
+}
+
+Register_test overflow_register("Overflow", Overflow_test);
+
+} // End namespace gold_testsuite.