diff options
| author | Sriraman Tallam <tmsriram@google.com> | 2014-05-13 10:51:48 -0700 |
|---|---|---|
| committer | Sriraman Tallam <tmsriram@google.com> | 2014-05-13 10:55:11 -0700 |
| commit | a82bef932ec11cc16f205427f8a056c3c0ea517d (patch) | |
| tree | 352f54fa01c8dc420676ee779b863fb457ba929d /gold/symtab.h | |
| parent | 033c337911594898b44678fa10b47ee19dd234b5 (diff) | |
| download | binutils-gdb-a82bef932ec11cc16f205427f8a056c3c0ea517d.tar.gz | |
With -pie and x86, the linker complains if it sees a PC-relative relocation
to access a global as it expects a GOTPCREL relocation. This is really not
necessary as the linker could use a copy relocation to get around it. This
patch enables copy relocations with pie.
Context:
This is useful because currently the GCC compiler with option -fpie makes
every extern global access go through the GOT. That is because the compiler
cannot tell if a global will end up being defined in the executable or not
and is conservative. This ends up hurting performance when the binary is linked
as mostly static where most of the globals do end up being defined in the
executable. By allowing copy relocs with fPIE, the compiler need not generate
a GOTPCREL(GOT access) for any global access. It can safely assume that all
globals will be defined in the executable and generate a PC-relative access
instead. Gold can then create a copy reloc for only the undefined globals.
gold/
* symtab.h (may_need_copy_reloc): Remove check for position independent
code.
* x86_64.cc (Target_x86_64<size>::Scan::global): Add check for no
position independence before pc absolute may_need_copy_reloc call.
Add check for executable output befor pc relative may_need_copy_reloc
call.
* i386.cc: Ditto.
* arm.cc: Ditto.
* sparc.cc: Ditto.
* tilegx.cc: Ditto.
* powerpc.cc: Add check for no position independence before
may_need_copy_reloc calls.
* testsuite/pie_copyrelocs_test.cc: New file.
* testsuite/pie_copyrelocs_shared_test.cc: New file.
* Makefile.am (pie_copyrelocs_test): New test.
* Makefile.in: Regenerate.
Diffstat (limited to 'gold/symtab.h')
| -rw-r--r-- | gold/symtab.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gold/symtab.h b/gold/symtab.h index b6366d4c9d2..ab5b5f97d7f 100644 --- a/gold/symtab.h +++ b/gold/symtab.h @@ -847,8 +847,7 @@ class Symbol bool may_need_copy_reloc() const { - return (!parameters->options().output_is_position_independent() - && parameters->options().copyreloc() + return (parameters->options().copyreloc() && this->is_from_dynobj() && !this->is_func()); } |