summaryrefslogtreecommitdiff
path: root/gold/gc.h
diff options
context:
space:
mode:
authorJoshua Oreman <oremanj@hudson-trading.com>2019-05-11 07:27:10 +0800
committerCary Coutant <ccoutant@gmail.com>2019-05-11 07:27:10 +0800
commite173ea00c2941af42ea4e2267446d6039a70da6e (patch)
treec4e71d797a234be5ce51cc9e18c3d922384e7a7e /gold/gc.h
parent1367480341749b1498a6c5e7a7b79c7a4ab4ed34 (diff)
downloadbinutils-gdb-e173ea00c2941af42ea4e2267446d6039a70da6e.tar.gz
Fix problem with ICF where diffs in EH frame info is ignored.
PR gold/21066 * gc.h (gc_process_relocs): Track relocations in .eh_frame sections when ICF is enabled, even though the .eh_frame sections themselves are not foldable. * icf.cc (get_section_contents): Change arguments to permit operation on just part of a section. Include extra identity regions in the referring section's contents recursively. (match_sections): Lock object here instead of in get_section_contents so that get_section_contents can operate recursively. (Icf::add_ehframe_links): New method. (Icf::find_identical_sections): Pass .eh_frame sections to add_ehframe_links(). Increase default iteration count from 2 to 3 because handling exception info typically requires one extra iteration. * icf.h (Icf::extra_identity_list_): New data member with accessor. (is_section_foldable_candidate): Include .gcc_except_table sections. * options.h: Update documentation for new default ICF iteration count. * testsuite/Makefile.am (icf_test_pr21066): New test case. * testsuite/Makefile.in: Regenerate. * testsuite/icf_test_pr21066.cc: New source file. * testsuite/icf_test_pr21066.sh: New test script.
Diffstat (limited to 'gold/gc.h')
-rw-r--r--gold/gc.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/gold/gc.h b/gold/gc.h
index 8dd0fc5dfd3..5f60934487f 100644
--- a/gold/gc.h
+++ b/gold/gc.h
@@ -200,7 +200,8 @@ gc_process_relocs(
bool check_section_for_function_pointers = false;
if (parameters->options().icf_enabled()
- && is_section_foldable_candidate(src_section_name.c_str()))
+ && (is_section_foldable_candidate(src_section_name)
+ || is_prefix_of(".eh_frame", src_section_name.c_str())))
{
is_icf_tracked = true;
Section_id src_id(src_obj, src_indx);